Skip to content

fix(vaults): fix delete modal for vault and plugin entities [khcp-9683] #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix(vaults): fix delete modal for vault and plugin entities [khcp-9683] #905

merged 2 commits into from
Nov 9, 2023

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Nov 9, 2023 •
edited
Loading

Summary

https://konghq.atlassian.net/browse/KHCP-9683
The good news is it affects only vaults and plugins
Tested Deploy Preview in khcp-ui: https://github.com/Kong/khcp-ui/pull/7120

Screenshot 2023-11-09 at 1 11 48 PM Screenshot 2023-11-09 at 1 12 28 PM

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@mptap mptap requested review from a team as code owners November 9, 2023 21:02
@mptap mptap self-assigned this Nov 9, 2023
lukewhchen
lukewhchen approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@lukewhchen lukewhchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mptap mptap enabled auto-merge (squash) November 9, 2023 21:21
kaiarrowood
kaiarrowood approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mptap mptap merged commit 3f1a8dd into main Nov 9, 2023
@mptap mptap deleted the fix/khcp-9683-fix-delete-modal-for-vault-entity branch November 9, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewhchen lukewhchen lukewhchen approved these changes

@kaiarrowood kaiarrowood kaiarrowood approved these changes

Assignees

@mptap mptap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mptap @lukewhchen @kaiarrowood