fix: data types matter folks...

marcelfolaron · marcelfolaron · commit 029315dc430f · 2025-03-07T14:39:57.000-05:00
This fixes an issue where we compare floats to 0 (int) but technically floats need to be compared to 0.0. In this case we don't particularly care the about the float itself we just need to figure out if there is an offset worth dealing with. casting to int is just fine.
diff --git a/app/Domain/Timesheets/Services/Timesheets.php b/app/Domain/Timesheets/Services/Timesheets.php
@@ -305,7 +305,7 @@ public function getWeeklyTimesheets(int $projectId, CarbonInterface $fromDate, i
             }
             // Detect timezone offset
 
-            $workdateOffsetStart = ($currentWorkDate->setToUserTimezone()->secondsSinceMidnight() / 60 / 60);
+            $workdateOffsetStart = (int) ($currentWorkDate->setToUserTimezone()->secondsSinceMidnight() / 60 / 60);
 
             // Various Entries can be in different timezones and thus would not be caught by upsert or grouping by
             // default Creating new rows for each timezone adjustment

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,7 @@ public function getWeeklyTimesheets(int $projectId, CarbonInterface $fromDate, i`
`305`	`305`	`}`
`306`	`306`	`// Detect timezone offset`
`307`	`307`
`308`		`- $workdateOffsetStart = ($currentWorkDate->setToUserTimezone()->secondsSinceMidnight() / 60 / 60);`
	`308`	`+ $workdateOffsetStart = (int) ($currentWorkDate->setToUserTimezone()->secondsSinceMidnight() / 60 / 60);`
`309`	`309`
`310`	`310`	`// Various Entries can be in different timezones and thus would not be caught by upsert or grouping by`
`311`	`311`	`// default Creating new rows for each timezone adjustment`