fix: better handling of news update failure

Author: marcelfolaron

app/Domain/Notifications/Hxcontrollers/News.php

@@ -3,6 +3,7 @@
 namespace Leantime\Domain\Notifications\Hxcontrollers;
 
 use Illuminate\Contracts\Container\BindingResolutionException;
+use Illuminate\Support\Facades\Log;
 use Leantime\Core\Controller\HtmxController;
 use Leantime\Domain\Menu\Services\Menu;
 use Leantime\Domain\Timesheets\Services\Timesheets;
@@ -34,11 +35,15 @@ public function init(\Leantime\Domain\Notifications\Services\News $newsService):
     public function get()
     {
 
+        $news = false;
         try {
             $news = $this->newsService->getLatest(session('userdata.id'));
 
         } catch (\Exception $e) {
-            report($e);
+            Log::warning('Could not connect to news server');
+        }
+
+        if ($news === false) {
             $news = 'Could not connect to news server';
         }
 

app/Domain/Notifications/Services/News.php

@@ -2,6 +2,7 @@
 
 namespace Leantime\Domain\Notifications\Services {
 
+    use Illuminate\Support\Facades\Log;
     use Leantime\Core\Db\Db as DbCore;
     use Leantime\Core\Language as LanguageCore;
     use Leantime\Domain\Notifications\Repositories\Notifications as NotificationRepository;
@@ -46,9 +47,16 @@ public function __construct(
         public function getLatest(int $userId): false|\SimpleXMLElement
         {
 
-            $rss = $this->getFeed();
+            try {
+                $rss = $this->getFeed();
+            } catch (\Exception $e) {
+                Log::warning('Could not connect to news server.');
+                Log::warning($e);
 
-            $latestGuid = strval($rss?->channel?->item[0]?->guid);
+                return false;
+            }
+
+            $latestGuid = (string) $rss?->channel?->item[0]?->guid;
             $this->settingService->saveSetting('usersettings.'.$userId.'.lastNewsGuid', strval($latestGuid));
 
             // Todo: check last article the user read
@@ -60,13 +68,20 @@ public function getLatest(int $userId): false|\SimpleXMLElement
         public function hasNews(int $userId): bool
         {
 
-            $rss = $this->getFeed();
+            try {
+                $rss = $this->getFeed();
+            } catch (\Exception $e) {
+                Log::warning('Could not connect to news server.');
+                Log::warning($e);
+
+                return false;
+            }
 
-            $latestGuid = strval($rss?->channel?->item[0]?->guid);
+            $latestGuid = (string) $rss?->channel?->item[0]?->guid;
 
             $lastNewsGuid = $this->settingService->getSetting('usersettings.'.$userId.'.lastNewsGuid');
 
-            if ($lastNewsGuid == false) {
+            if ($lastNewsGuid === false) {
                 return true;
             }