Skip to content

Commit 5b8537e

Browse files
author
Itroublve
authored
fix: keystore file not found exception (ReVanced#57)
* fix: keystore file not found exception * the fix * fix oopsies
1 parent 7d8a61c commit 5b8537e

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/main/kotlin/app/revanced/cli/signing/Signing.kt

+2-3
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@ object Signing {
1818
// the reason is, in case the signer fails
1919
// it does not damage the output file
2020
println("[signing]")
21-
val keyStore = Signer(signingOptions).signApk(alignedOutput, signedOutput)
21+
Signer(signingOptions).signApk(alignedOutput, signedOutput)
2222

23-
// afterwards copy over the file and the keystore to the output
23+
// afterwards copy over the file to the output
2424
signedOutput.copyTo(outputFile, true)
25-
keyStore.copyTo(outputFile.resolveSibling(keyStore.name), true)
2625
}
2726
}

src/main/kotlin/app/revanced/utils/signing/Signer.kt

+1-3
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ internal class Signer(
4949
return JcaX509CertificateConverter().getCertificate(builder.build(signer)) to pair.private
5050
}
5151

52-
fun signApk(input: File, output: File): File {
52+
fun signApk(input: File, output: File) {
5353
Security.addProvider(BouncyCastleProvider())
5454

5555
// TODO: keystore should be saved securely
@@ -74,7 +74,5 @@ internal class Signer(
7474
signer.setOutputApk(output)
7575

7676
signer.build().sign()
77-
78-
return ks
7977
}
8078
}

0 commit comments

Comments
 (0)