Skip to content

Change default TokenModifiers global color #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
comedinha opened this issue Apr 29, 2024 · 0 comments
Open

Change default TokenModifiers global color #2646

comedinha opened this issue Apr 29, 2024 · 0 comments

Comments

@comedinha
Copy link
Contributor

comedinha commented Apr 29, 2024

In the vscode, these is the standard tokens defined: https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#standard-token-types-and-modifiers
Doen't exist a "variable.global" token to TokenModifiers, and "variable.static" token was removed in #1458 this modification makes the global variable become the same color as local variable if it isn't is configured. This forces everyone to need to go configure manually.

So I think is better to use some standard token to the themes automatically color globals and locals variables.
My suggestion is use the token "variable.definition" or "variable.readonly".

"variable.definition" is used in self, so if it will be accepted the suggestion is change self to "variable.static" or "variable.readonly"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant