-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Move everest headers #10091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Move everest headers #10091
Conversation
718bc49
to
e52f454
Compare
f2bf78f
to
7886668
Compare
0c6bfbf
to
aa4a4a5
Compare
a9e3c37
to
a120596
Compare
a120596
to
4148c53
Compare
2a63f05
to
083bfd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cheers! (Also just wanted to double check that this patch validates the tf-psa-crypto
one and the framework
one and that those two are not expected to work on their own)
083bfd7
to
74ca553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the .gitmodules
change
.gitmodules
Outdated
url = [email protected]:bjwtaylor/TF-PSA-Crypto.git | ||
[submodule "framework"] | ||
path = framework | ||
url = [email protected]:bjwtaylor/mbedtls-framework.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No change to .gitmodules
is needed. The submodule state references a commit sha, and GitHub makes that sha available through any fork. As soon as you push the commit to your fork, it's available from the normal URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is temporary, it's just to test the dependent PR. It will be removed prior to the merge.
073f539
to
8dcc956
Compare
39c5a99
to
9a845ce
Compare
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
Signed-off-by: Ben Taylor <[email protected]>
7c44495
to
b593381
Compare
Description
Remove everest headers from mbedtls depends Mbed-TLS/mbedtls-framework#153 resolves Mbed-TLS/TF-PSA-Crypto#229
PR checklist