Skip to content

Move everest headers #10091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

bjwtaylor
Copy link

@bjwtaylor bjwtaylor commented Mar 24, 2025

Description

Remove everest headers from mbedtls depends Mbed-TLS/mbedtls-framework#153 resolves Mbed-TLS/TF-PSA-Crypto#229

PR checklist

@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch 13 times, most recently from 718bc49 to e52f454 Compare March 31, 2025 08:14
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch 5 times, most recently from f2bf78f to 7886668 Compare April 2, 2025 08:50
@bjwtaylor bjwtaylor changed the title added version of mbedtls for framework testing Move everest headers Apr 2, 2025
@bjwtaylor bjwtaylor changed the title Move everest headers Remove everest headers Apr 3, 2025
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from 0c6bfbf to aa4a4a5 Compare April 3, 2025 09:53
@bjwtaylor bjwtaylor changed the title Remove everest headers Move everest headers Apr 3, 2025
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from a9e3c37 to a120596 Compare April 3, 2025 13:51
@bjwtaylor bjwtaylor marked this pull request as ready for review April 4, 2025 06:43
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 8, 2025
@felixc-arm felixc-arm self-requested a review April 15, 2025 10:01
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from a120596 to 4148c53 Compare April 16, 2025 09:39
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch 6 times, most recently from 2a63f05 to 083bfd7 Compare April 23, 2025 06:56
felixc-arm
felixc-arm previously approved these changes Apr 23, 2025
Copy link
Contributor

@felixc-arm felixc-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers! (Also just wanted to double check that this patch validates the tf-psa-crypto one and the framework one and that those two are not expected to work on their own)

@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from 083bfd7 to 74ca553 Compare April 23, 2025 11:53
@gilles-peskine-arm gilles-peskine-arm self-requested a review April 24, 2025 09:32
@gilles-peskine-arm gilles-peskine-arm added priority-high High priority - will be reviewed soon and removed needs-reviewer This PR needs someone to pick it up for review labels Apr 24, 2025
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the .gitmodules change

.gitmodules Outdated
url = [email protected]:bjwtaylor/TF-PSA-Crypto.git
[submodule "framework"]
path = framework
url = [email protected]:bjwtaylor/mbedtls-framework.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No change to .gitmodules is needed. The submodule state references a commit sha, and GitHub makes that sha available through any fork. As soon as you push the commit to your fork, it's available from the normal URL.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is temporary, it's just to test the dependent PR. It will be removed prior to the merge.

@gilles-peskine-arm gilles-peskine-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 24, 2025
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from 073f539 to 8dcc956 Compare April 29, 2025 07:42
@bjwtaylor bjwtaylor added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels May 1, 2025
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from 39c5a99 to 9a845ce Compare May 1, 2025 07:08
@bjwtaylor bjwtaylor force-pushed the move-everest-headers branch from 7c44495 to b593381 Compare May 8, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon
Projects
Development

Successfully merging this pull request may close these issues.

Move Everest headers to a private subdirectory
3 participants