Skip to content

Commit 8651a43

Browse files
author
Hanno Becker
committed
Remove %zu format string from ssl_client2 and ssl_server2
1 parent db108ac commit 8651a43

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

programs/ssl/ssl_client2.c

+10-9
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,9 @@ int main( void )
286286
" force_ciphersuite=<name> default: all enabled\n"\
287287
" acceptable ciphersuite names:\n"
288288

289+
#define ALPN_LIST_SIZE 10
290+
#define CURVE_LIST_SIZE 20
291+
289292
/*
290293
* global options
291294
*/
@@ -440,10 +443,10 @@ int main( int argc, char *argv[] )
440443
size_t psk_len = 0;
441444
#endif
442445
#if defined(MBEDTLS_SSL_ALPN)
443-
const char *alpn_list[10];
446+
const char *alpn_list[ALPN_LIST_SIZE];
444447
#endif
445448
#if defined(MBEDTLS_ECP_C)
446-
mbedtls_ecp_group_id curve_list[20];
449+
mbedtls_ecp_group_id curve_list[CURVE_LIST_SIZE];
447450
const mbedtls_ecp_curve_info *curve_cur;
448451
#endif
449452

@@ -972,8 +975,7 @@ int main( int argc, char *argv[] )
972975
else if( strcmp( p, "default" ) != 0 )
973976
{
974977
/* Leave room for a final NULL in curve list */
975-
while( i < (int) ( sizeof( curve_list ) / sizeof( *curve_list ) ) - 1
976-
&& *p != '\0' )
978+
while( i < CURVE_LIST_SIZE - 1 && *p != '\0' )
977979
{
978980
q = p;
979981

@@ -1004,11 +1006,10 @@ int main( int argc, char *argv[] )
10041006

10051007
mbedtls_printf("Number of curves: %d\n", i );
10061008

1007-
if( i == (int) ( sizeof( curve_list ) / sizeof( *curve_list ) ) - 1
1008-
&& *p != '\0' )
1009+
if( i == CURVE_LIST_SIZE - 1 && *p != '\0' )
10091010
{
1010-
mbedtls_printf( "curves list too long, maximum %zu",
1011-
(size_t) ( sizeof( curve_list ) / sizeof( *curve_list ) - 1 ) );
1011+
mbedtls_printf( "curves list too long, maximum %d",
1012+
CURVE_LIST_SIZE - 1 );
10121013
goto exit;
10131014
}
10141015

@@ -1024,7 +1025,7 @@ int main( int argc, char *argv[] )
10241025
i = 0;
10251026

10261027
/* Leave room for a final NULL in alpn_list */
1027-
while( i < (int) sizeof alpn_list - 1 && *p != '\0' )
1028+
while( i < ALPN_LIST_SIZE - 1 && *p != '\0' )
10281029
{
10291030
alpn_list[i++] = p;
10301031

programs/ssl/ssl_server2.c

+10-9
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,9 @@ int main( void )
375375
" acceptable ciphersuite names:\n"
376376

377377

378+
#define ALPN_LIST_SIZE 10
379+
#define CURVE_LIST_SIZE 20
380+
378381
#define PUT_UINT64_BE(out_be,in_le,i) \
379382
{ \
380383
(out_be)[(i) + 0] = (unsigned char)( ( (in_le) >> 56 ) & 0xFF ); \
@@ -886,11 +889,11 @@ int main( int argc, char *argv[] )
886889
sni_entry *sni_info = NULL;
887890
#endif
888891
#if defined(MBEDTLS_ECP_C)
889-
mbedtls_ecp_group_id curve_list[20];
892+
mbedtls_ecp_group_id curve_list[CURVE_LIST_SIZE];
890893
const mbedtls_ecp_curve_info * curve_cur;
891894
#endif
892895
#if defined(MBEDTLS_SSL_ALPN)
893-
const char *alpn_list[10];
896+
const char *alpn_list[ALPN_LIST_SIZE];
894897
#endif
895898
#if defined(MBEDTLS_MEMORY_BUFFER_ALLOC_C)
896899
unsigned char alloc_buf[100000];
@@ -1453,8 +1456,7 @@ int main( int argc, char *argv[] )
14531456
else if( strcmp( p, "default" ) != 0 )
14541457
{
14551458
/* Leave room for a final NULL in curve list */
1456-
while( i < (int) ( sizeof( curve_list ) / sizeof( *curve_list ) ) - 1
1457-
&& *p != '\0' )
1459+
while( i < CURVE_LIST_SIZE - 1 && *p != '\0' )
14581460
{
14591461
q = p;
14601462

@@ -1485,11 +1487,10 @@ int main( int argc, char *argv[] )
14851487

14861488
mbedtls_printf("Number of curves: %d\n", i );
14871489

1488-
if( i == (int) ( sizeof( curve_list ) / sizeof( *curve_list ) ) - 1
1489-
&& *p != '\0' )
1490+
if( i == CURVE_LIST_SIZE - 1 && *p != '\0' )
14901491
{
1491-
mbedtls_printf( "curves list too long, maximum %zu",
1492-
(size_t) ( sizeof( curve_list ) / sizeof( *curve_list ) - 1 ) );
1492+
mbedtls_printf( "curves list too long, maximum %d",
1493+
CURVE_LIST_SIZE - 1 );
14931494
goto exit;
14941495
}
14951496

@@ -1505,7 +1506,7 @@ int main( int argc, char *argv[] )
15051506
i = 0;
15061507

15071508
/* Leave room for a final NULL in alpn_list */
1508-
while( i < (int) sizeof alpn_list - 1 && *p != '\0' )
1509+
while( i < ALPN_LIST_SIZE - 1 && *p != '\0' )
15091510
{
15101511
alpn_list[i++] = p;
15111512

0 commit comments

Comments
 (0)