Patches cleanup & fixes (#112)

Changes:
- Remove unnecessary patches
- GH-89 Clean patches and their authors
- GH-105 Fix invalid projectiles knockback
- GH-109 Fix 1.7 not working properly
- Remove `[Paper-0196] Fix block break desync` patch - it was implemented in really weird way
- Add `[Tuinity-0051] Optimise non-flush packet sending` patch - it was listed as PandaSpigot patch, but it wasn't even implemented

Author: P3ridot

README.md

@@ -75,32 +75,37 @@ Titanium implements patches from other engines as well. **All credits go to the
 [Paper-0072] Fix Furnace cook time bug when lagging by Aikar
 [Paper-0072] Only process BlockPhysicsEvent if a plugin has a listener by Aikar
 [Paper-0076] Optimized light level comaprsions by Aikar
+[Paper-0077] Add World Util Methods by Aikar
 [Paper-0085] Use a Shared Random for Entities
 [Paper-0090] Improve Maps (in item frames) performance and bug fixes by Aikar
 [Paper-0101] Do not load chunks for light check by Aikar
 [Paper-0116] Fix Bugs with Spigot Mob Spawn Logic by Aikar
 [Paper-0118] Prevent Fire from loading chunks by Aikar
 [Paper-0121] Reduce IO ops opening a new region
 [Paper-0127] Do not load chunks for pathfinding by Aikar
+[Paper-0135] Avoid blocking on Network Manager creation by Aikar
+[Paper-0137] Faster redstone torch rapid clock removal by Martin Panzer
 [Paper-0144] Improve Minecraft Hopper Performance
 [Paper-0156] Auto Save Improvements by Aikar
 [Paper-0161] Disable Vanilla Chunk GC by Aikar
 [Paper-0168] Disable ticking of snow blocks
 [Paper-0168] Cache user authenticator threads by vemacs
 [Paper-0173] Optimize World.isLoaded(BlockPosition)
+[Paper-0175] Don't let fishinghooks use portals by Zach Brown
 [Paper-0180] Server Tick Events
 [Paper-0186] Prevent Pathfinding out of World Border by Aikar
 [Paper-0192] Make legacy ping handler more reliable by Minecrell
-[Paper-0196] Fix block break desync by Michael Himing
 [Paper-0201] Remove CraftScheduler Async Task Debugger by Aikar
 [Paper-0202] Shame on you Mojang moves chunk loading off https thread
+[Paper-0210] Use TerminalConsoleAppender for console improvements by Minecrell
 [Paper-0232] Fix MC-117075: TE Unload Lag Spike by mezz
 [Paper-0276] Improved Async Task Scheduler by Aikar
 [Paper-0088/0277] Ability to change PlayerProfile in AsyncPreLoginEvent by Aikar
 [Paper-0287] MC-124833 by Zach Brown
 [Paper-0302] Don't load chunks for villager door check by Aikar
 [Paper-0313] Optimized world time updates by Aikar
 [Paper-0321] Cleanup allocated favicon ByteBuf
+[Paper-0328] Optimize Network Manager and add advanced packet support by Aikar
 [Paper-0332] Add More information to Entity.toString() by Aikar
 [Paper-0342] Always process chunk removal in removeEntity by Aikar 2018
 [Paper-0344] [MC-111480] Start Entity ID's at 1
@@ -119,6 +124,7 @@ Titanium implements patches from other engines as well. **All credits go to the
 [Paper-0206/0432] Add Raw Byte ItemStack Serialization by Mariell Hoversholm
 [Paper-0451] Load Chunks for Login Asynchronously by Aikar
 [Paper-0242/0614] Player Chunk Load/Unload Events by ysl3000
+[Paper-0740] Add Unix domain socket support by Andrew Steinborn
 [Paper-0797] Use Velocity compression and cipher natives by Elier
 
 [Taco-0006] Fix hopper lag by making entities look for hoppers by Techcable
@@ -172,24 +178,15 @@ Titanium implements patches from other engines as well. **All credits go to the
 [PandaSpigot-0005] Add internal setMaxStackSize method for materials by hpfxd
 [PandaSpigot-0004/0005] Backport PlayerHandshakeEvent from Paper by hpfxd
 [PandaSpigot-0006] Update to Netty 4.1.x by hpfxd 
-[PandaSpigot-0007] Add Unix domain socket support by hpfxd
 [PandaSpigot-0008] Remove hacky stackable buckets code by hpfxd
 [PandaSpigot-0009] Improved plugins command by hpfxd
-[PandaSpigot-0010] Optimize Network Manager and add advanced packet support by hpfxd
-[PandaSpigot-0011] Allow controlled flushing for network manager by hpfxd
-[PandaSpigot-0012] Consolidate flush calls for entity tracker packets by hpfxd
-[PandaSpigot-0013] Optimise non-flush packet sending by hpfxd
-[PandaSpigot-0028] Avoid blocking on Network Manager creation by hpfxd
 [PandaSpigot-0033] Configurable arrow trajectory by hpfxd
-[PandaSpigot-0034] Prevent fishing hooks from using portals by hpfxd
 [PandaSpigot-0010/0037] Backport PlayerProfile API by hpfxd
 [PandaSpigot-0039] Optimize VarInt reading and writing by hpfxd
 [PandaSpigot-0040] Various micro-optimizations for PacketDataSerializer by hpfxd
-[PandaSpigot-0041] Use TerminalConsoleAppender for console improvements by hpfxd
 [PandaSpigpt-0049] Add setting for proxy online mode status by hpfxd
 [PandaSpigot-0050] Metrics by hpfxd
 [PandaSpigot-0054] Disconnect for payload errors by uRyanxD
-[PandaSpigot-0056] Faster redstone torch rapid clock removal by uRyanxD
 [PandaSpigot-0060] Optimise removeQueue by hpfxd
 
 [IonSpigot-0003] Explosion Improvements by SuicidalKids
@@ -221,6 +218,10 @@ Titanium implements patches from other engines as well. **All credits go to the
 [Purpur-0049/0290] Remove Timings by BillyGalbreath
 [Purpur-0291] Remove Mojang Profiler by BillyGalbreath
 
+[Tuinity-0008] Allow controlled flushing for network manager by Spottedleaf
+[Tuinity-0046] Consolidate flush calls for entity tracker packets by Spottedleaf
+[Tuinity-0051] Optimise non-flush packet sending by Spottedleaf
+
 [Yatopia-0030] Don't save Fireworks and Arrows by tr7zw
 [Yatopia-0047] Smarter statistics ticking
 

build.gradle

@@ -16,6 +16,7 @@ allprojects {
     }
 
     repositories {
+        mavenCentral()
         maven { url 'https://libraries.minecraft.net' }
         maven { url 'https://repo.titanvale.net/releases' }
         maven { url 'https://repo.titanvale.net/snapshots' }

patches/api/0011-Setup-Gradle-project.patch renamed to patches/api/0001-Setup-Gradle-project.patch

@@ -20,29 +20,28 @@ index edf9e5c3afdfcb9e357974d6536d25bd828d67b0..dfa15b1d499bd8bf1cb6b81441d0d409
 
 diff --git a/build.gradle b/build.gradle
 new file mode 100644
-index 0000000000000000000000000000000000000000..45aafcce4ef6ae0e0fa01eba5f174a501f1a3ca0
+index 0000000000000000000000000000000000000000..a9a3e5af8057128b24b51fe07a7cd2914b205991
 --- /dev/null
 +++ b/build.gradle
-@@ -0,0 +1,45 @@
+@@ -0,0 +1,56 @@
 +dependencies {
 +    // Minecraft libraries start
-+    api 'commons-lang:commons-lang:2.6'
-+    api 'com.googlecode.json-simple:json-simple:1.1.1'
-+    api 'org.avaje:ebean:2.8.1'
-+    api 'org.yaml:snakeyaml:1.15'
-+    api 'net.md-5:bungeecord-chat:1.8-SNAPSHOT'
-+
-+    // bundled with Minecraft, should be kept in sync
 +    api 'com.google.guava:guava:17.0'
 +    api 'com.google.code.gson:gson:2.2.4'
++    api 'net.md-5:bungeecord-chat:1.8-SNAPSHOT'
++    api 'org.yaml:snakeyaml:1.15'
++    api ('com.googlecode.json-simple:json-simple:1.1.1') {
++        transitive = false
++    }
++    api 'org.avaje:ebean:2.8.1'
++    api 'commons-lang:commons-lang:2.6'
 +
 +    compileOnlyApi 'net.sf.trove4j:trove4j:3.0.3' // provided by CraftBukkit
 +    // Minecraft libraries end
 +
-+    // Titanium start - Use okaeri-configs for server configuration
-+    api 'eu.okaeri:okaeri-configs-yaml-bukkit:4.0.6'
-+    api 'eu.okaeri:okaeri-configs-serdes-commons:4.0.6'
-+    // Titanium end
++    // Titanium libraries start
++    api 'org.apache.commons:commons-lang3:3.12.0' // Titanium - updated commons-lang3 to 3.12.0 // Titanium - Add commons-lang3 to API
++    // Titanium libraries end
 +
 +    testImplementation 'junit:junit:4.13.2' // Titanium - Updated junit to 4.13.2
 +    testImplementation 'org.hamcrest:hamcrest-library:1.3'
@@ -57,6 +56,18 @@ index 0000000000000000000000000000000000000000..45aafcce4ef6ae0e0fa01eba5f174a50
 +    file.write "version=${project.version}"
 +}
 +
++shadowJar {
++    dependsOn generateApiVersioningFile
++    from(layout.buildDirectory.file("pom.properties")) {
++        into("META-INF/maven/${project.group}/${project.name.toLowerCase()}")
++    }
++
++    manifest {
++        attributes(
++                "Automatic-Module-Name": "org.bukkit"
++        )
++    }
++}
 +jar {
 +    dependsOn generateApiVersioningFile
 +    from(layout.buildDirectory.file("pom.properties")) {
@@ -72,42 +83,49 @@ index 0000000000000000000000000000000000000000..45aafcce4ef6ae0e0fa01eba5f174a50
 \ No newline at end of file
 diff --git a/pom.xml b/pom.xml
 deleted file mode 100644
-index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..0000000000000000000000000000000000000000
+index fe9d6d265b686ae1c373e4fdcd202b16673366f1..0000000000000000000000000000000000000000
 --- a/pom.xml
 +++ /dev/null
-@@ -1,187 +0,0 @@
+@@ -1,161 +0,0 @@
 -
 -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 -         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
 -    <modelVersion>4.0.0</modelVersion>
 -
 -    <parent>
--        <groupId>net.titanvale</groupId>
--        <artifactId>titanium-parent</artifactId>
--        <version>1.8.8-SNAPSHOT</version>
+-        <groupId>org.github.paperspigot</groupId>
+-        <artifactId>paperspigot-parent</artifactId>
+-        <version>dev-SNAPSHOT</version>
 -    </parent>
 -
--    <name>Titanium-API</name>
--    <artifactId>titanium-api</artifactId>
+-    <groupId>org.github.paperspigot</groupId>
+-    <artifactId>paperspigot-api</artifactId>
 -    <version>1.8.8-R0.1-SNAPSHOT</version>
 -    <packaging>jar</packaging>
 -
+-    <name>PaperSpigot-API</name>
+-    <url>https://hub.spigotmc.org/stash/projects/PAPER/</url>
+-    <description>An enhanced plugin API for Minecraft servers.</description>
+-
 -    <properties>
 -        <!--PaperSpigot - Bump to 1.8 - This will haunt me -->
 -        <additionalparam>-Xdoclint:none</additionalparam>
 -        <maven.compiler.source>1.8</maven.compiler.source>
 -        <maven.compiler.target>1.8</maven.compiler.target>
 -        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
--        <!-- Titanium - since submodules inherit this from titanium-parent -->
--        <maven.deploy.skip>false</maven.deploy.skip>
 -    </properties>
 -
--    <repositories>
+-    <!-- just until we get deployment to central approved -->
+-    <distributionManagement>
 -        <repository>
--            <id>jitpack-io</id>
--            <url>https://jitpack.io</url>
+-            <id>destroystokyo-releases</id>
+-            <url>https://repo.destroystokyo.com/content/repositories/releases/</url>
 -        </repository>
--    </repositories>
+-        <snapshotRepository>
+-            <id>destroystokyo-snapshots</id>
+-            <url>https://repo.destroystokyo.com/content/repositories/snapshots/</url>
+-        </snapshotRepository>
+-    </distributionManagement>
 -
 -    <!-- required until fixed plexus-compiler-eclipse is deployed -->
 -    <pluginRepositories>
@@ -119,11 +137,6 @@ index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..00000000000000000000000000000000
 -
 -    <dependencies>
 -        <dependency>
--            <groupId>com.google.code.findbugs</groupId>
--            <artifactId>jsr305</artifactId>
--            <version>3.0.2</version>
--        </dependency>
--        <dependency>
 -            <groupId>net.sf.trove4j</groupId>
 -            <artifactId>trove4j</artifactId>
 -            <version>3.0.3</version>
@@ -154,7 +167,7 @@ index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..00000000000000000000000000000000
 -        <dependency>
 -            <groupId>com.google.code.gson</groupId>
 -            <artifactId>gson</artifactId>
--            <version>2.2.4</version>
+-          <version>2.2.4</version>
 -        </dependency>
 -        <dependency>
 -            <groupId>org.avaje</groupId>
@@ -169,27 +182,18 @@ index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..00000000000000000000000000000000
 -            <scope>compile</scope>
 -        </dependency>
 -        <dependency>
--            <groupId>com.github.Electroid</groupId>
--            <artifactId>BungeeCord</artifactId>
--            <version>master</version>
+-            <groupId>net.md-5</groupId>
+-            <artifactId>bungeecord-chat</artifactId>
+-            <version>1.8-SNAPSHOT</version>
 -            <type>jar</type>
 -            <scope>compile</scope>
 -        </dependency>
--        <dependency>
--            <groupId>eu.okaeri</groupId>
--            <artifactId>okaeri-configs-yaml-bukkit</artifactId>
--            <version>4.0.0-beta18</version>
--        </dependency>
--        <dependency>
--            <groupId>eu.okaeri</groupId>
--            <artifactId>okaeri-configs-serdes-commons</artifactId>
--            <version>4.0.0-beta18</version>
--        </dependency>
+-
 -        <!-- testing -->
 -        <dependency>
 -            <groupId>junit</groupId>
 -            <artifactId>junit</artifactId>
--            <version>4.13.2</version>
+-            <version>4.12</version>
 -            <scope>test</scope>
 -        </dependency>
 -        <dependency>
@@ -206,7 +210,7 @@ index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..00000000000000000000000000000000
 -                <groupId>org.apache.maven.plugins</groupId>
 -                <artifactId>maven-compiler-plugin</artifactId>
 -                <!-- versions after this appear to be broken -->
--                <version>3.10.1</version>
+-                <version>3.1</version>
 -                <configuration>
 -                    <!-- we use the Eclipse compiler as it doesn't need a JDK -->
 -                    <compilerId>eclipse</compilerId>
@@ -225,7 +229,7 @@ index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..00000000000000000000000000000000
 -            <plugin>
 -                <groupId>org.apache.maven.plugins</groupId>
 -                <artifactId>maven-shade-plugin</artifactId>
--                <version>3.3.0</version>
+-                <version>2.3</version>
 -                <executions>
 -                    <execution>
 -                        <phase>package</phase>
@@ -241,25 +245,6 @@ index 2ff99a888a04e285fb9bf10cb5cf5560a60227ba..00000000000000000000000000000000
 -                    <shadedArtifactAttached>true</shadedArtifactAttached>
 -                </configuration>
 -            </plugin>
--            <plugin>
--                <groupId>org.apache.maven.plugins</groupId>
--                <artifactId>maven-source-plugin</artifactId>
--                <version>3.2.0</version>
--                <executions>
--                    <execution>
--                        <id>attach-sources</id>
--                        <phase>verify</phase>
--                        <goals>
--                            <goal>jar-no-fork</goal>
--                        </goals>
--                    </execution>
--                </executions>
--            </plugin>
--            <plugin>
--                <groupId>org.apache.maven.plugins</groupId>
--                <artifactId>maven-deploy-plugin</artifactId>
--                <version>3.0.0-M2</version>
--            </plugin>
 -        </plugins>
 -    </build>
 -</project>
@@ -284,15 +269,3 @@ index 7e89b97b60d547c75bde6d54f1512b0277099034..56e932b84ee8cde6a86d7a4f4cc562dd
          } catch (Exception ignored) {}
 
          new AuthorNagException("Deprecated use of CustomTimingsHandler. Please Switch to Timings.of ASAP").printStackTrace();
-diff --git a/src/test/java/org/bukkit/DifficultyTest.java b/src/test/java/org/bukkit/DifficultyTest.java
-index 293e283a22fdc2abb387c29239cc3391f7cb6a4f..9ef39817d0df126e74c121073b71b3a881e949f8 100644
---- a/src/test/java/org/bukkit/DifficultyTest.java
-+++ b/src/test/java/org/bukkit/DifficultyTest.java
-@@ -2,6 +2,7 @@ package org.bukkit;
- 
- import static org.hamcrest.CoreMatchers.is;
- import static org.junit.Assert.assertThat;
-+import static org.junit.Assert.assertTrue;
- 
- import org.junit.Test;
-