Skip to content

GIF button appears below toolbar in certain breakpoints #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mshunjan opened this issue Feb 13, 2024 · 4 comments · May be fixed by #79
Open

GIF button appears below toolbar in certain breakpoints #73

mshunjan opened this issue Feb 13, 2024 · 4 comments · May be fixed by #79
Labels
bug Something isn't working

Comments

@mshunjan
Copy link

Hi @N1ck . Thanks for the lovely tool. The problem was encountered on version 24.1.18 in both chrome (121.0.6167.185) and firefox (122.0.1).

Current Behavior

image

The GIF button renders below the toolbar at certain breakpoints. Specifically, when there is no more whitespace for the toolbar buttons, it gets rendered below.

Expected behavior

The GIF button gets moved to the menu (triple dot) items, or is placed within the toolbar.

Steps to reproduce

  1. Create a new issue on github.
  2. Resize browser horizontally until toolbar shrinks to displace GIF button.
@N1ck N1ck added the bug Something isn't working label Mar 17, 2024
@dsayling
Copy link

dsayling commented Apr 3, 2024

When enabled with "Refined Github" it appears to add multiple gif buttons that don't do anything along with the icon shortcuts for the table and collapsable content.

image

@PatrykKuniczak
Copy link

PatrykKuniczak commented Jul 24, 2024 •
edited
Loading

image

Each, on the smaller width, it's occur somewhere in textarea, it's annoying

I using Chrome latest on Win 11

@Jonghakseo Jonghakseo linked a pull request Aug 3, 2024 that will close this issue
Open
@Jonghakseo
Copy link

Jonghakseo commented Aug 3, 2024 •
edited
Loading

@mshunjan @dsayling @PatrykKuniczak :)

I submitted a pull request (#79), If you want to use it locally before deployment, please unzip the file below and import it in developer mode

In details

  1. Open in browser - chrome://extensions
  2. Check - Developer mode
  3. Find and Click - Load unpacked extension
  4. Select - distribution folder you unzipped

distribution.zip

@PatrykKuniczak
Copy link

@Jonghakseo Gold boy ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed UI breaking on narrow screens Jonghakseo/gifs-for-github
5 participants
@N1ck @dsayling @mshunjan @Jonghakseo @PatrykKuniczak