Skip to content

NIS Sharpening is broken on DirectX 11 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doodlum opened this issue Mar 5, 2025 · 2 comments
Open

NIS Sharpening is broken on DirectX 11 #53

doodlum opened this issue Mar 5, 2025 · 2 comments
Labels
ack Acknowledged. We may or may not do something, but won’t commit either way.

Comments

@doodlum
Copy link

doodlum commented Mar 5, 2025

Since updating Streamline to the latest version, the NIS plugin does not work correctly. Sometimes it works, sometimes it doesn't.

No errors will be reported by NIS. slEvaluateFeature will return sl::Result::eOk but no sharpening is applied.

Calling

		sl::NISOptions nisOptions{};
		nisOptions.mode = sl::NISMode::eSharpen;
		nisOptions.hdrMode = sl::NISHDR::eNone;
		nisOptions.sharpness = a_sharpness;

		if (SL_FAILED(result, slNISSetOptions(viewport, nisOptions))) {
			logger::critical("[Streamline] Could not set NIS options");
		}

Returns no errors either.

Probably unrelated to this bug report but the latest Streamline might have major performance issues as well, based on reports from many users of reduced performance since updating.

@jake-nv jake-nv added the ack Acknowledged. We may or may not do something, but won’t commit either way. label Mar 20, 2025
@jake-nv
Copy link
Collaborator

jake-nv commented Mar 20, 2025

I’ve used it recently with dx12 (and maybe Vk), and NIS SDK shipped with dx11 support (https://github.com/NVIDIAGameWorks/NVIDIAImageScaling). If this is broken it’s likely a regression.

@doodlum
Copy link
Author

doodlum commented Mar 20, 2025

I think regression because the only changes I made were related to updating Streamline from 2.0.1 to latest. It would only seem to initialise for me if DLSS was enabled on startup then when disabled NIS would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Acknowledged. We may or may not do something, but won’t commit either way.
Projects
None yet
Development

No branches or pull requests

2 participants