Skip to content

Validate Bidirectional distortion Field Texture #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simco50 opened this issue May 8, 2025 · 0 comments
Open

Validate Bidirectional distortion Field Texture #63

simco50 opened this issue May 8, 2025 · 0 comments

Comments

@simco50
Copy link

simco50 commented May 8, 2025

Hi,

The documentation describes being able to provide a bidirectional distortion field but it's not entirely clear what space it should be.

The documentation says this:

Units: the buffer values should be in normalized pixel space [0,1].

But the contents of the buffer describe the relative offset of the UV coordinates after being distorted, so this can be negative?
While the code snippet contains this, which contradicts the doc

// The output can be outside of the [0, 1] range
Texture2D[UV] = float4(rg, ba); // needs to be **signed**

Also this:

These should be the same scale as the input MVecs

Is this the scale of the data in the motion vector texture before or after being scaled by sl::Constants::mvecScale?

Given that there are no tools to see what the distortion texture is doing with the other inputs, it's very hard to verify the correctness of the distortion texture.
The debug view in the ImGui plugin shows that all the inputs (eg. Motion/Depth) are unaffected by the distortion texture. So again, hard to validate.

Any futher details would be helpful.

Thanks,
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant