Enable Nsys gpu device metrics #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good mostly, can you add a test for this in test/core/execution/test_launcher.py? |
|
Also, you will need to signoff your commits to pass the DCO check. |
Signed-off-by: ashbhandare <[email protected]>
Signed-off-by: ashbhandare <[email protected]>
ashbhandare
force-pushed
the
llmb_gpu_metrics
branch
from
70a0df4 to
51b8479
Compare
hemildesai
reviewed
Jun 10, 2025
| role.entrypoint = "nsys" | ||
| role.args = nsys_prefix + role.args | ||
| role.entrypoint, nsys_postfix = executor.get_nsys_entrypoint() | ||
| role.args = nsys_prefix + role.args + [nsys_postfix] |
There was a problem hiding this comment.
Can you wrap this in an if condition? i.e. only add the postfix if its not empty.
hemildesai
approved these changes
Jun 10, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU metrics must only be enabled on a single rank on a node for a distributed job while profiling with nsys.