Skip to content

Add ruff.toml, pre-commit #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ruff.toml, pre-commit #264

wants to merge 2 commits into from

Conversation

hemildesai
Copy link
Contributor

No description provided.

@hemildesai
Add ruff.toml, pre-commit
6ca24dd 
Signed-off-by: Hemil Desai <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 8, 2025
View reviewed changes
nemo_run/cli/api.py
@@ -61,21 +61,22 @@
from nemo_run.cli import devspace as devspace_cli
from nemo_run.cli import experiment as experiment_cli
from nemo_run.cli.cli_parser import parse_cli_args, parse_factory
from nemo_run.cli.config import ConfigSerializer
from nemo_run.cli.lazy import LazyEntrypoint

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
nemo_run.cli.lazy
Loading
begins an import cycle.

Copilot Autofix

AI 5 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

nemo_run/cli/lazy.py
import os

from omegaconf import OmegaConf

from nemo_run.cli.config import ConfigSerializer

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
nemo_run.cli.config
Loading
begins an import cycle.

Copilot Autofix

AI 5 days ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

test/cli/test_api.py

import nemo_run as run
import nemo_run.cli.cli_parser # Import the module to mock its function

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'nemo_run' is not used.

Copilot Autofix

AI 5 days ago

To fix the issue, the unused import statement import nemo_run.cli.cli_parser on line 31 should be removed. This will eliminate the unnecessary dependency and improve code readability. No additional changes are required, as the removal of this import does not affect the functionality of the code.

Suggested changeset 1
test/cli/test_api.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/test/cli/test_api.py b/test/cli/test_api.py
--- a/test/cli/test_api.py
+++ b/test/cli/test_api.py
@@ -30,3 +30,3 @@
 import nemo_run as run
-import nemo_run.cli.cli_parser  # Import the module to mock its function
+
 from nemo_run import cli, config
EOF
@@ -30,3 +30,3 @@
import nemo_run as run
import nemo_run.cli.cli_parser # Import the module to mock its function

from nemo_run import cli, config
Copilot is powered by AI and may make mistakes. Always verify output.
@hemildesai
fix
a0ebeb4 
Signed-off-by: Hemil Desai <[email protected]>
@hemildesai hemildesai requested review from ko3n1g and chtruong814 June 9, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ko3n1g ko3n1g Awaiting requested review from ko3n1g

@chtruong814 chtruong814 Awaiting requested review from chtruong814

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hemildesai