Skip to content

Commit 9a9d7f0

Browse files
committed
feat: Try to submit review before exit
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
1 parent f70bed6 commit 9a9d7f0

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/scripts/run_cpp_linter.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@
2323
if output.returncode != 0:
2424
comment = '''There are some changes that do not conform to C++ style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
2525
approval = 'REQUEST_CHANGES'
26-
exit(1)
2726

2827
pr.create_review(commit, comment, approval)
2928

30-
29+
if output.returncode != 0:
30+
exit(1)
31+
else:
32+
exit(0)

.github/scripts/run_py_linter.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323
if output.returncode != 0:
2424
comment = '''There are some changes that do not conform to Python style guidelines:\n ```diff\n{}```'''.format(output.stdout.decode("utf-8"))
2525
approval = 'REQUEST_CHANGES'
26-
exit(1)
2726

2827
pr.create_review(commit, comment, approval)
28+
29+
if output.returncode != 0:
30+
exit(1)
31+
else:
32+
exit(0)

0 commit comments

Comments
 (0)