Skip to content

Commit 98140e5

Browse files
committed
Addressed comments
1 parent 7b279fa commit 98140e5

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

metaflow/client/core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1672,7 +1672,7 @@ def control_tasks(self, *tags: str) -> Iterator[Task]:
16721672
Yields
16731673
------
16741674
Task
1675-
Control Task object for this step
1675+
Control Task objects for this step
16761676
"""
16771677
children = super(Step, self).__iter__()
16781678
for child in children:

metaflow/decorators.py

+5
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,11 @@ def _init_step_decorators(flow, graph, environment, flow_datastore, logger):
549549

550550
FlowSpecDerived = TypeVar("FlowSpecDerived", bound=FlowSpec)
551551

552+
# The StepFlag is a "fake" input item to be able to distinguish
553+
# callables and those that have had a `@step` decorator on them. This enables us
554+
# to check the ordering of decorators (ie: put @step first) with the type
555+
# system. There should be a better way to do this with a more flexible type
556+
# system but this is what works for now with the Python type system
552557
StepFlag = NewType("StepFlag", bool)
553558

554559

stubs/setup.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
include_package_data=True,
88
name="metaflow-stubs",
99
version=version,
10-
description="Metaflow: More Data Science, Less Engineering",
11-
long_description=open("../README.md").read(),
12-
long_description_content_type="text/markdown",
10+
description="Metaflow Stubs: Stubs for the metaflow package",
1311
author="Metaflow Developers",
1412
author_email="[email protected]",
1513
license="Apache Software License",
@@ -26,6 +24,7 @@
2624
"Programming Language :: Python :: 3.9",
2725
"Programming Language :: Python :: 3.10",
2826
"Programming Language :: Python :: 3.11",
27+
"Programming Language :: Python :: 3.12",
2928
],
3029
project_urls={
3130
"Source": "https://github.com/Netflix/metaflow",

0 commit comments

Comments
 (0)