feat(utils) parse the first author of multiple comma seperated authors (#447)

Author: clemgbld

.changeset/proud-yaks-run.md

@@ -0,0 +1,5 @@
+---
+"@nodesecure/utils": minor
+---
+
+feat(utils): can parse the first author of multiple comma seperated authors

workspaces/utils/src/parseManifestAuthor.ts

@@ -22,7 +22,7 @@ export function parseManifestAuthor(
     return null;
   }
 
-  const match = manifestAuthorRegex().exec(manifestAuthorField);
+  const match = matchManifestAuthor(manifestAuthorField);
   if (!match) {
     return null;
   }
@@ -44,6 +44,15 @@ export function parseManifestAuthor(
   return author;
 }
 
+function matchManifestAuthor(manifestAuthorField: string) {
+  const match = manifestAuthorRegex().exec(manifestAuthorField);
+  if (match) {
+    return match;
+  }
+
+  return manifestAuthorRegex().exec(manifestAuthorField.split(",")[0]);
+}
+
 export function parseAuthor(author: any): ParsedMaintainer | null {
   if (typeof author === "string") {
     return parseManifestAuthor(author);

workspaces/utils/test/parseManifestAuthor.spec.ts

@@ -103,4 +103,30 @@ describe("parseManifestAuthor", () => {
       assert.strictEqual(error.message, "expected manifestAuthorField to be a string");
     }
   });
+
+  it("should be able to parse a name with a comma in it", () => {
+    const result = utils.parseManifestAuthor("aaa,bbb");
+    assert.deepEqual(result, {
+      name: "aaa,bbb"
+    });
+  });
+
+  describe("multiple authors seperated by comma", () => {
+    it("should be able to parse the first author when there is mutliple authors separated by comma", () => {
+      const result = utils.parseManifestAuthor("John Doe <[email protected]>, Alicia B <[email protected]>");
+      assert.deepEqual(result, {
+        name: "John Doe",
+        email: "[email protected]"
+      });
+    });
+
+    it("should be able to parse the first author author field with name and URL", () => {
+      const result = utils.parseManifestAuthor("John-David Dalton (http://allyoucanleet.com/), Alicia B (http://a.com/)");
+      assert.deepEqual(result, {
+        name: "John-David Dalton",
+        url: "http://allyoucanleet.com/"
+      });
+    });
+  });
 });
+