-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Add automation to prevent PRs from changing specification files that need to be immutable. #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can help with this. Which file paths would we like to restrict? Would we want an override mechanism? |
This issue needs some extra clarifications. For example, what files should we forbid? Should we forbid the files that we auto-generate, like the produced JSON spec files? Also, if we need to forbid extra files, do we need to forbid them based on the branch that you are about to merge? For example, you can update 3.1.0 spec only when you are about to merge your PR in the |
Partial solution in A possible refinement is to check in the workflow whether the PR is an intra-repo "sync PR" or "release PR" and report "ok" for these. Conditions would be
|
It is very hard for people to know which specification file to update when making changes. If people do mistakenly try and change the wrong file we should prevent that and provide guidance as to which is the correct file to edit.
The text was updated successfully, but these errors were encountered: