feat: error scenario test cases, refactor: consistent hashing

Author: rudransh-shrivastava

backend/tests/apps/github/management/commands/github_update_external_repositories_test.py

@@ -2,6 +2,7 @@
 from unittest import mock
 
 import pytest
+from github.GithubException import BadCredentialsException
 
 from apps.github.management.commands.github_update_external_repositories import (
     Command,
@@ -119,12 +120,13 @@ def test_handle(self, scenario):
         mock_project = mock.Mock(spec=Project)
 
         def sync_side_effect(repo):
-            idx = hash(repo.name) % len(orgs) if orgs else 0
+            # Use deterministic mapping based on repo name
+            idx = sum(ord(c) for c in repo.name) % len(orgs) if orgs else 0
             return (orgs[idx], mock.Mock(project=mock_project))
 
         self.mock_sync_repository.side_effect = sync_side_effect
 
-        with mock.patch("builtins.print"):
+        with mock.patch("builtins.print"):  # Suppress command output during testing
             self.command.handle()
 
         assert self.mock_gh.get_organization.call_count == scenario.num_orgs
@@ -165,3 +167,57 @@ def test_sync_organization_repositories(
 
     assert len(projects) == expected_project_count
     assert mock_sync_repository.call_count == num_repos
+
+
+@pytest.mark.parametrize(
+    ("side_effects", "expected_project_count"),
+    [
+        # First repo fails with error, second succeeds with project
+        (
+            [
+                Exception("GitHub API error"),
+                (mock.Mock(spec=Organization), mock.Mock(project=mock.Mock(spec=Project))),
+            ],
+            1,
+        ),
+        # First repo fails with network error, second succeeds with project
+        (
+            [
+                ConnectionError("Network timeout"),
+                (mock.Mock(spec=Organization), mock.Mock(project=mock.Mock(spec=Project))),
+            ],
+            1,
+        ),
+        # Credential error should return None immediately
+        (BadCredentialsException(401), None),
+    ],
+)
+@mock.patch("apps.github.management.commands.github_update_external_repositories.sync_repository")
+def test_sync_organization_repositories_error_handling(
+    mock_sync_repository, command, mock_gh_repository, side_effects, expected_project_count
+):
+    """Test repository synchronization error handling."""
+    mock_organization = mock.Mock(spec=Organization)
+    mock_organization.login = "TestOrg"
+
+    mock_repositories = mock.MagicMock()
+    mock_repositories.totalCount = 2  # Try to sync 2 repositories
+    mock_repositories.__iter__.return_value = [mock_gh_repository] * 2
+
+    mock_sync_repository.side_effect = side_effects
+
+    with mock.patch("builtins.print"):  # Suppress command output during testing
+        projects = command.sync_organization_repositories(mock_organization, mock_repositories)
+
+    if isinstance(side_effects, BadCredentialsException):
+        assert projects is None
+        assert mock_sync_repository.call_count == 1
+    else:
+        assert (
+            len(projects) == expected_project_count
+        )  # Should get 1 project from second successful repo
+        assert mock_sync_repository.call_count == 2  # Should try both repos
+        # For successful cases, verify repository was added to project
+        if projects:
+            assert len(projects) == 1
+            projects[0].repositories.add.assert_called_once()