Validate blob sidecar: check bad parent first (#15013)

terencechain · web-flow · commit 997a9112d1e7 · 2025-03-05T17:54:44.000Z
diff --git a/beacon-chain/sync/validate_blob.go b/beacon-chain/sync/validate_blob.go
@@ -92,11 +92,11 @@ func (s *Service) validateBlob(ctx context.Context, pid peer.ID, msg *pubsub.Mes
 		return pubsub.ValidationIgnore, err
 	}
 
-	if err := vf.ValidProposerSignature(ctx); err != nil {
+	if err := vf.SidecarParentValid(s.hasBadBlock); err != nil {
 		return pubsub.ValidationReject, err
 	}
 
-	if err := vf.SidecarParentValid(s.hasBadBlock); err != nil {
+	if err := vf.ValidProposerSignature(ctx); err != nil {
 		return pubsub.ValidationReject, err
 	}
 
diff --git a/changelog/tt_validate_block.md b/changelog/tt_validate_block.md
@@ -0,0 +1,3 @@
+### Changed
+
+- Validate blob sidecar re-order signature and bad parent block.

Original file line number	Diff line number	Diff line change
`@@ -92,11 +92,11 @@ func (s Service) validateBlob(ctx context.Context, pid peer.ID, msg pubsub.Mes`
`92`	`92`	`return pubsub.ValidationIgnore, err`
`93`	`93`	`}`
`94`	`94`
`95`		`- if err := vf.ValidProposerSignature(ctx); err != nil {`
	`95`	`+ if err := vf.SidecarParentValid(s.hasBadBlock); err != nil {`
`96`	`96`	`return pubsub.ValidationReject, err`
`97`	`97`	`}`
`98`	`98`
`99`		`- if err := vf.SidecarParentValid(s.hasBadBlock); err != nil {`
	`99`	`+ if err := vf.ValidProposerSignature(ctx); err != nil {`
`100`	`100`	`return pubsub.ValidationReject, err`
`101`	`101`	`}`
`102`	`102`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+### Changed`
	`2`	`+`
	`3`	`+- Validate blob sidecar re-order signature and bad parent block.`