Set removeEnumValuePrefix to false by default (#20452)

wing328 · web-flow · commit 09530b4781af · 2025-01-13T16:25:10.000+08:00
* set removeEnumValuePrefix to false by default

* update tests
diff --git a/bin/configs/java-okhttp-gson.yaml b/bin/configs/java-okhttp-gson.yaml
@@ -15,6 +15,7 @@ additionalProperties:
   useOneOfDiscriminatorLookup: true
   disallowAdditionalPropertiesIfNotPresent: false
   useReflectionEqualsHashCode:: true
+  removeEnumValuePrefix: true
 enumNameMappings:
   s: LOWER_CASE_S
   S: UPPER_CASE_S
diff --git a/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java b/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
@@ -297,7 +297,7 @@ apiTemplateFiles are for API outputs only (controllers/handlers).
     // acts strictly upon a spec, potentially modifying it to have consistent behavior across generators.
     protected boolean strictSpecBehavior = true;
     // flag to indicate whether enum value prefixes are removed
-    protected boolean removeEnumValuePrefix = true;
+    protected boolean removeEnumValuePrefix = false;
 
     // Support legacy logic for evaluating discriminators
     @Setter protected boolean legacyDiscriminatorBehavior = true;
diff --git a/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java b/modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java
@@ -889,6 +889,7 @@ public void updateCodegenPropertyEnumWithExtension() {
     @Test
     public void updateCodegenPropertyEnumWithPrefixRemoved() {
         final DefaultCodegen codegen = new DefaultCodegen();
+        codegen.setRemoveEnumValuePrefix(true);
         CodegenProperty enumProperty = codegenProperty(Arrays.asList("animal_dog", "animal_cat"));
 
         codegen.updateCodegenPropertyEnum(enumProperty);
@@ -925,6 +926,7 @@ public void updateCodegenPropertyEnumWithoutPrefixRemoved() {
     @Test
     public void postProcessModelsEnumWithPrefixRemoved() {
         final DefaultCodegen codegen = new DefaultCodegen();
+        codegen.setRemoveEnumValuePrefix(true);
         ModelsMap objs = codegenModel(Arrays.asList("animal_dog", "animal_cat"));
         CodegenModel cm = objs.getModels().get(0).getModel();
 
diff --git a/samples/client/petstore/java/okhttp-gson-3.1/docs/CodesEnum.md b/samples/client/petstore/java/okhttp-gson-3.1/docs/CodesEnum.md
@@ -5,11 +5,11 @@
 ## Enum
 
 
-* `_1` (value: `"Code 1"`)
+* `CODE_1` (value: `"Code 1"`)
 
-* `_2` (value: `"Code 2"`)
+* `CODE_2` (value: `"Code 2"`)
 
-* `_3` (value: `"Code 3"`)
+* `CODE_3` (value: `"Code 3"`)
 
 
 
diff --git a/samples/client/petstore/java/okhttp-gson-3.1/src/main/java/org/openapitools/client/model/CodesEnum.java b/samples/client/petstore/java/okhttp-gson-3.1/src/main/java/org/openapitools/client/model/CodesEnum.java
@@ -29,11 +29,11 @@
 @JsonAdapter(CodesEnum.Adapter.class)
 public enum CodesEnum {
   
-  _1("Code 1"),
+  CODE_1("Code 1"),
   
-  _2("Code 2"),
+  CODE_2("Code 2"),
   
-  _3("Code 3");
+  CODE_3("Code 3");
 
   private String value;
 
diff --git a/samples/client/petstore/rust/hyper/petstore/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/hyper/petstore/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/hyper0x/petstore/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/hyper0x/petstore/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest-trait/petstore/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest-trait/petstore/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore-async-middleware/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore-async-middleware/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore-async-tokensource/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore-async-tokensource/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore-async/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore-async/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore-avoid-box/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore-avoid-box/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore-awsv4signature/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore-awsv4signature/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore-model-name-prefix/src/models/foo_unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore-model-name-prefix/src/models/foo_unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl FooUniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/rust/reqwest/petstore/src/models/unique_item_array_testing.rs b/samples/client/petstore/rust/reqwest/petstore/src/models/unique_item_array_testing.rs
@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]
 pub enum UniqueItemArray {
     #[serde(rename = "unique_item_1")]
-    Variant1,
+    UniqueItem1,
     #[serde(rename = "unique_item_2")]
-    Variant2,
+    UniqueItem2,
     #[serde(rename = "unique_item_3")]
-    Variant3,
+    UniqueItem3,
 }
 
 impl Default for UniqueItemArray {
     fn default() -> UniqueItemArray {
-        Self::Variant1
+        Self::UniqueItem1
     }
 }
 
diff --git a/samples/client/petstore/typescript-axios/builds/with-complex-headers/api.ts b/samples/client/petstore/typescript-axios/builds/with-complex-headers/api.ts
@@ -74,8 +74,8 @@ export interface Category {
  */
 
 export const MediaType = {
-    Json: 'application/json',
-    Xml: 'application/xml'
+    ApplicationJson: 'application/json',
+    ApplicationXml: 'application/xml'
 } as const;
 
 export type MediaType = typeof MediaType[keyof typeof MediaType];

Original file line number	Diff line number	Diff line change
`@@ -31,16 +31,16 @@ impl UniqueItemArrayTesting {`
`31`	`31`	`#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]`
`32`	`32`	`pub enum UniqueItemArray {`
`33`	`33`	`#[serde(rename = "unique_item_1")]`
`34`		`- Variant1,`
	`34`	`+ UniqueItem1,`
`35`	`35`	`#[serde(rename = "unique_item_2")]`
`36`		`- Variant2,`
	`36`	`+ UniqueItem2,`
`37`	`37`	`#[serde(rename = "unique_item_3")]`
`38`		`- Variant3,`
	`38`	`+ UniqueItem3,`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`impl Default for UniqueItemArray {`
`42`	`42`	`fn default() -> UniqueItemArray {`
`43`		`- Self::Variant1`
	`43`	`+ Self::UniqueItem1`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -31,16 +31,16 @@ impl FooUniqueItemArrayTesting {`
`31`	`31`	`#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Hash, Serialize, Deserialize)]`
`32`	`32`	`pub enum UniqueItemArray {`
`33`	`33`	`#[serde(rename = "unique_item_1")]`
`34`		`- Variant1,`
	`34`	`+ UniqueItem1,`
`35`	`35`	`#[serde(rename = "unique_item_2")]`
`36`		`- Variant2,`
	`36`	`+ UniqueItem2,`
`37`	`37`	`#[serde(rename = "unique_item_3")]`
`38`		`- Variant3,`
	`38`	`+ UniqueItem3,`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`impl Default for UniqueItemArray {`
`42`	`42`	`fn default() -> UniqueItemArray {`
`43`		`- Self::Variant1`
	`43`	`+ Self::UniqueItem1`
`44`	`44`	`}`
`45`	`45`	`}`
`46`	`46`