Skip to content

Commit 2bf708d

Browse files
authored
deprecated netstandard, uwp support in csharp (#4214)
1 parent 5766fca commit 2bf708d

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

docs/generators/csharp.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ sidebar_label: csharp
1010
|sourceFolder|source folder for generated code| |src|
1111
|packageGuid|The GUID that will be associated with the C# project| |null|
1212
|interfacePrefix|Prefix interfaces with a community standard or widely accepted prefix.| |I|
13-
|targetFramework|The target .NET framework version.|<dl><dt>**v3.5**</dt><dd>.NET Framework 3.5 compatible</dd><dt>**v4.0**</dt><dd>.NET Framework 4.0 compatible</dd><dt>**v4.5**</dt><dd>.NET Framework 4.5+ compatible</dd><dt>**v5.0**</dt><dd>.NET Standard 1.3 compatible</dd><dt>**uwp**</dt><dd>Universal Windows Platform (IMPORTANT: this will be decommissioned and replaced by v5.0)</dd><dl>|v4.5|
13+
|targetFramework|The target .NET framework version.|<dl><dt>**v3.5**</dt><dd>.NET Framework 3.5 compatible</dd><dt>**v4.0**</dt><dd>.NET Framework 4.0 compatible</dd><dt>**v4.5**</dt><dd>.NET Framework 4.5+ compatible</dd><dt>**v5.0**</dt><dd>.NET Standard 1.3 compatible (DEPRECATED. Please use `csharp-netcore` generator instead)</dd><dt>**uwp**</dt><dd>Universal Windows Platform (DEPRECATED. Please use `csharp-netcore` generator instead)</dd><dl>|v4.5|
1414
|modelPropertyNaming|Naming convention for the property: 'camelCase', 'PascalCase', 'snake_case' and 'original', which keeps the original name| |PascalCase|
1515
|hideGenerationTimestamp|Hides the generation timestamp when files are generated.| |true|
1616
|sortParamsByRequiredFlag|Sort method arguments to place required parameters before optional parameters.| |true|

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CSharpClientCodegen.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@ public CSharpClientCodegen() {
132132
.put(NET35, ".NET Framework 3.5 compatible")
133133
.put(NET40, ".NET Framework 4.0 compatible")
134134
.put(NET45, ".NET Framework 4.5+ compatible")
135-
.put(NETSTANDARD, ".NET Standard 1.3 compatible")
136-
.put(UWP, "Universal Windows Platform (IMPORTANT: this will be decommissioned and replaced by v5.0)")
135+
.put(NETSTANDARD, ".NET Standard 1.3 compatible (DEPRECATED. Please use `csharp-netcore` generator instead)")
136+
.put(UWP, "Universal Windows Platform (DEPRECATED. Please use `csharp-netcore` generator instead)")
137137
.build();
138138
framework.defaultValue(this.targetFramework);
139139
framework.setEnum(frameworks);
@@ -276,6 +276,7 @@ public void processOpts() {
276276
setValidatable(Boolean.FALSE);
277277
setSupportsAsync(Boolean.FALSE);
278278
} else if (NETSTANDARD.equals(this.targetFramework)) {
279+
LOGGER.warn(".NET Standard 1.3 support has been DEPRECATED in this generator. Please use `csharp-netcore` generator instead.");
279280
// TODO: NETSTANDARD here is misrepresenting a PCL v5.0 which supports .NET Framework 4.6+, .NET Core 1.0, and Windows Universal 10.0
280281
additionalProperties.put(MCS_NET_VERSION_KEY, "4.6-api");
281282
if (additionalProperties.containsKey("supportsUWP")) {
@@ -293,6 +294,8 @@ public void processOpts() {
293294
//Todo implement it
294295
excludeTests = true;
295296
} else if (UWP.equals(this.targetFramework)) {
297+
LOGGER.warn("UWP support has been DEPRECATED in this generator. Please use `csharp-netcore` generator instead.");
298+
// TODO: NETSTANDARD here is misrepresenting a PCL v5.0 which supports .NET Framework 4.6+, .NET Core 1.0, and Windows Universal 10.0
296299
setTargetFrameworkNuget("uwp");
297300
setSupportsAsync(Boolean.TRUE);
298301
setSupportsUWP(Boolean.TRUE);

0 commit comments

Comments
 (0)