Skip to content

Commit 5a7b471

Browse files
ybelenkowing328
authored andcommitted
Mark Slim3 server generator as deprecated (#4256)
* Mark Slim3 server generator as deprecated * Add deprecated suffix
1 parent d5b09cf commit 5a7b471

File tree

8 files changed

+37
-7
lines changed

8 files changed

+37
-7
lines changed

bin/ci/php-slim-server-petstore.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"generatorName": "php-slim",
2+
"generatorName": "php-slim-deprecated",
33
"inputSpec": "modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml",
44
"outputDir": "samples/server/petstore/php-slim",
55
"templateDir": "modules/openapi-generator/src/main/resources/php-slim-server"

bin/openapi3/php-slim-server-petstore.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ fi
2727

2828
# if you've executed sbt assembly previously it will use that instead.
2929
export JAVA_OPTS="${JAVA_OPTS} -Xmx1024M -DloggerPath=conf/log4j.properties"
30-
ags="generate -t modules/openapi-generator/src/main/resources/php-slim-server -i modules/openapi-generator/src/test/resources/3_0/petstore.yaml -g php-slim -o samples/server/petstore/php-slim $@"
30+
ags="generate -t modules/openapi-generator/src/main/resources/php-slim-server -i modules/openapi-generator/src/test/resources/3_0/petstore.yaml -g php-slim-deprecated -o samples/server/petstore/php-slim $@"
3131

3232
java $JAVA_OPTS -jar $executable $ags

bin/php-slim-server-petstore.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ fi
2727

2828
# if you've executed sbt assembly previously it will use that instead.
2929
export JAVA_OPTS="${JAVA_OPTS} -Xmx1024M -DloggerPath=conf/log4j.properties"
30-
ags="generate -t modules/openapi-generator/src/main/resources/php-slim-server -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g php-slim -o samples/server/petstore/php-slim $@"
30+
ags="generate -t modules/openapi-generator/src/main/resources/php-slim-server -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g php-slim-deprecated -o samples/server/petstore/php-slim $@"
3131

3232
java $JAVA_OPTS -jar $executable $ags

bin/windows/php-slim-server-petstore.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ If Not Exist %executable% (
55
)
66

77
REM set JAVA_OPTS=%JAVA_OPTS% -Xmx1024M
8-
set ags=generate -i modules\openapi-generator\src\test\resources\2_0\petstore-with-fake-endpoints-models-for-testing.yaml -g php-slim -o samples\server\petstore\php-slim
8+
set ags=generate -i modules\openapi-generator\src\test\resources\2_0\petstore-with-fake-endpoints-models-for-testing.yaml -g php-slim-deprecated -o samples\server\petstore\php-slim
99

1010
java %JAVA_OPTS% -jar %executable% %ags%

docs/generators.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ The following generators are available:
103103
* [php-laravel](generators/php-laravel.md)
104104
* [php-lumen](generators/php-lumen.md)
105105
* [php-silex](generators/php-silex.md)
106-
* [php-slim](generators/php-slim.md)
106+
* [php-slim-deprecated (deprecated)](generators/php-slim-deprecated.md)
107107
* [php-slim4](generators/php-slim4.md)
108108
* [php-symfony](generators/php-symfony.md)
109109
* [php-ze-ph](generators/php-ze-ph.md)
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
---
2+
title: Config Options for php-slim-deprecated
3+
sidebar_label: php-slim-deprecated
4+
---
5+
6+
| Option | Description | Values | Default |
7+
| ------ | ----------- | ------ | ------- |
8+
|sortParamsByRequiredFlag|Sort method arguments to place required parameters before optional parameters.| |true|
9+
|ensureUniqueParams|Whether to ensure parameter names are unique in an operation (rename parameters that are not).| |true|
10+
|allowUnicodeIdentifiers|boolean, toggles whether unicode identifiers are allowed in names or not, default is false| |false|
11+
|prependFormOrBodyParameters|Add form or body parameters to the beginning of the parameter list.| |false|
12+
|modelPackage|package for generated models| |null|
13+
|apiPackage|package for generated api classes| |null|
14+
|variableNamingConvention|naming convention of variable name, e.g. camelCase.| |camelCase|
15+
|invokerPackage|The main namespace to use for all classes. e.g. Yay\Pets| |null|
16+
|packageName|The main package name for classes. e.g. GeneratedPetstore| |null|
17+
|srcBasePath|The directory to serve as source root.| |null|
18+
|artifactVersion|The version to use in the composer package version field. e.g. 1.2.3| |null|

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpSlim4ServerCodegen.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import org.apache.commons.lang3.StringEscapeUtils;
2323
import org.apache.commons.lang3.StringUtils;
2424
import org.openapitools.codegen.*;
25+
import org.openapitools.codegen.meta.GeneratorMetadata;
26+
import org.openapitools.codegen.meta.Stability;
2527
import org.slf4j.Logger;
2628
import org.slf4j.LoggerFactory;
2729

@@ -44,6 +46,10 @@ public class PhpSlim4ServerCodegen extends PhpSlimServerCodegen {
4446
public PhpSlim4ServerCodegen() {
4547
super();
4648

49+
generatorMetadata = GeneratorMetadata.newBuilder(generatorMetadata)
50+
.stability(Stability.STABLE)
51+
.build();
52+
4753
outputFolder = "generated-code" + File.separator + "slim4";
4854
embeddedTemplateDir = templateDir = "php-slim4-server";
4955

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpSlimServerCodegen.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
import org.apache.commons.lang3.StringEscapeUtils;
2424
import org.apache.commons.lang3.StringUtils;
2525
import org.openapitools.codegen.*;
26+
import org.openapitools.codegen.meta.GeneratorMetadata;
27+
import org.openapitools.codegen.meta.Stability;
2628
import org.slf4j.Logger;
2729
import org.slf4j.LoggerFactory;
2830

@@ -46,6 +48,10 @@ public class PhpSlimServerCodegen extends AbstractPhpCodegen {
4648
public PhpSlimServerCodegen() {
4749
super();
4850

51+
generatorMetadata = GeneratorMetadata.newBuilder(generatorMetadata)
52+
.stability(Stability.DEPRECATED)
53+
.build();
54+
4955
// clear import mapping (from default generator) as slim does not use it
5056
// at the moment
5157
importMapping.clear();
@@ -85,12 +91,12 @@ public CodegenType getTag() {
8591

8692
@Override
8793
public String getName() {
88-
return "php-slim";
94+
return "php-slim-deprecated";
8995
}
9096

9197
@Override
9298
public String getHelp() {
93-
return "Generates a PHP Slim Framework server library.";
99+
return "Generates a PHP Slim Framework server library. IMPORTANT NOTE: this generator (Slim 3.x) is no longer actively maintained so please use 'php-slim4' generator instead.";
94100
}
95101

96102
@Override

0 commit comments

Comments
 (0)