[AVRO] Fix the package handling for the avro generator (#3987) (#4078)

* [AVRO] Fix the package handling for the avro generator (#3987)

Also fix an issue with the outputFolder that wasn't overridable through opts

* Update sample files through avro-petstore.sh

There's an issue with inlined object but it's already present with the previous commit

* Revert the fix on outputFolder (not a bug)

Author: Choobz

modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AvroSchemaCodegen.java

@@ -43,8 +43,8 @@ public AvroSchemaCodegen() {
 
         outputFolder = "generated-code/avro-schema";
         modelTemplateFiles.put("model.mustache", ".avsc");
-        apiPackage = "api";
-        modelPackage = "model";
+        // Force the model package to the package name so import can be fully qualified
+        modelPackage = packageName;
         importMapping.clear();
         embeddedTemplateDir = templateDir = AVRO;
 
@@ -81,10 +81,12 @@ public void processOpts() {
         super.processOpts();
         if (additionalProperties.containsKey(CodegenConstants.PACKAGE_NAME)) {
             packageName = (String) additionalProperties.get(CodegenConstants.PACKAGE_NAME);
+
+            // Force the model package to the package name so import can be fully qualified
+            modelPackage = packageName;
         }
 
         additionalProperties.put("packageName", packageName);
-
     }
 
     @Override
@@ -132,4 +134,4 @@ public String escapeQuotationMark(String input) {
         return input;
     }
 
-}
+}

samples/openapi3/schema/petstore/avro-schema/.openapi-generator/VERSION

@@ -1 +1 @@
-4.1.1-SNAPSHOT
+4.2.0-SNAPSHOT

samples/openapi3/schema/petstore/avro-schema/InlineObject1.avsc

@@ -11,7 +11,7 @@
     },
     {
       "name": "file",
-      "type": ["null", "model.File"],
+      "type": ["null", ],
       "doc": "file to upload"
     }
   ]