Skip to content

[typescript-fetch] (4.0.X) format: date parameters should not include time component #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
someone1 opened this issue Nov 27, 2018 · 0 comments

Comments

@someone1
Copy link
Contributor

Description

Currently, when a request is generated via the typescript-fetch client, type: string/format:date parameters include a time component when it should not.

openapi-generator version

openapi-generator-cli-4.0.0-20181126.024631-44

OpenAPI declaration file content or url
swagger: "2.0"
info:
  title: "Simple Test"

paths:
  "/get/Simple":
    get:
      summary: Retrieve List of Simple
      operationId: "get.Simple"
      responses:
        200:
          description: OK
          schema:
            $ref: "#/definitions/Simple"

definitions:         
  Simple:
    type: object
    required:
      - Name
    properties:
      Date:
        type: string
        format: date

Output:

import { exists } from '../runtime';
/**
 * 
 * @export
 * @interface Simple
 */
export interface Simple {
    /**
     * 
     * @type {Date}
     * @memberof Simple
     */
    date?: Date;
}

export function SimpleFromJSON(json: any): Simple {
    return {
        'date': !exists(json, 'Date') ? undefined : new Date(json['Date']),
    };
}

export function SimpleToJSON(value?: Simple): any {
    if (value === undefined) {
        return undefined;
    }
    return {
        'Date': value.date === undefined ? undefined : value.date.toISOString(),
    };
}
Command line used for generation

openapi-generator generate -i openapi.yaml -l typescript-fetch -c es6.json -o ./typescript-api/

Steps to reproduce
  1. Use the provided yaml excerpt above to generate a client with the provided command line
  2. Buggy code generated
Related issues/PRs

PR #569

Suggest a fix/enhancement

Update template to take substring of ISO date to only include the date portion when format: date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant