Skip to content

F2.stringify is being called on all messages #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holsted opened this issue Jun 26, 2014 · 2 comments · Fixed by #304
Closed

F2.stringify is being called on all messages #173

holsted opened this issue Jun 26, 2014 · 2 comments · Fixed by #304
Labels

Comments

@holsted
Copy link

holsted commented Jun 26, 2014

When calling F2.Events.emit(), the params are being stringified regardless if the apps are secure or not. This introduces a performance issue in IE8 with large objects being passed through. The problematic line appears to be line 238 of rpc.js.

@ilinkuo
Copy link

ilinkuo commented Jun 27, 2014

I think this is a different concern, but shares the same solution as #46 -- use a whitelist to filter the AppConfig before serializing -- because most of what's in the AppConfig doesn't need to go over the wire.

@markhealey
Copy link
Member

Linking to line 238. @FajitaNachos do you have a test case (or jsfiddle) showing this?

@brianbaker brianbaker linked a pull request Jul 15, 2021 that will close this issue
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants