Skip to content

Commit c64efec

Browse files
committed
clean it a bit
1 parent b48711e commit c64efec

File tree

1 file changed

+21
-5
lines changed

1 file changed

+21
-5
lines changed

docker-brew-openmandriva/mkimage-dnf.sh

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,24 @@ while true; do
3838
esac
3939
done
4040

41+
if [ -z $(command -v docker) ]; then
42+
printf '%s\n' "Missing docker. Installing..."
43+
44+
dnf --refresh \
45+
--nogpgcheck \
46+
--setopt=install_weak_deps=False \
47+
--nodocs \
48+
--assumeyes \
49+
install docker
50+
51+
if [ $? != 0 ]; then
52+
printf '%s\n' "Installing docker failed."
53+
errorCatch
54+
fi
55+
fi
56+
4157
if [ -z "${installversion}" ]; then
42-
# Attempt to match host version
58+
# Attempt to match host version
4359
if grep -q Cooker /etc/os-release; then
4460
installversion=cooker
4561
elif grep -q Rolling /etc/os-release; then
@@ -56,7 +72,7 @@ fi
5672
[ -z "$arch" ] && arch="$(uname -m)"
5773
[ -z "$rootfsdir" ] && rootfsdir="$common_pwd/docker-brew-openmandriva/${installversion}"
5874

59-
target=$(mktemp -d --tmpdir="$(realpath $(dirname $0))" $(basename $0).XXXXXX)
75+
target="$(mktemp -d --tmpdir=$(realpath $(dirname $0)) $(basename $0).XXXXXX)"
6076
mkdir -m 755 "$target"/dev
6177
mknod -m 600 "$target"/dev/console c 5 1
6278
mknod -m 600 "$target"/dev/initctl p
@@ -201,11 +217,11 @@ else
201217
tarFile="${rootfsdir}"/rootfs-"${installversion}".tar.xz
202218
fi
203219

204-
pushd "${target}"
220+
cd "${target}"
205221

206222
tar --numeric-owner -caf "${tarFile}" -c .
207223
[ "${rootfsdir}" = "$common_pwd/docker-brew-openmandriva/$installversion" ] || mv -f "${tarFile}" $common_pwd/docker-brew-openmandriva/$installversion/
208-
pushd $common_pwd/docker-brew-openmandriva/$installversion/
224+
cd $common_pwd/docker-brew-openmandriva/$installversion/
209225
docker build --tag=openmandriva/$installversion:$arch --file Dockerfile .
210226

211227
docker run -i -t --rm openmandriva/$installversion:$arch /bin/sh -c "printf '%s\n' success"
@@ -237,5 +253,5 @@ if [ ! -z "${builder}" ]; then
237253
docker manifest push openmandriva/builder:latest
238254
fi
239255

240-
popd
256+
cd ..
241257
rm -rf "${target}"

0 commit comments

Comments
 (0)