Skip to content

MagicAnimalCarousel simpler solution? #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
politicalnonconformist opened this issue Mar 23, 2025 · 1 comment
Open

MagicAnimalCarousel simpler solution? #779

politicalnonconformist opened this issue Mar 23, 2025 · 1 comment

Comments

@politicalnonconformist
Copy link

Looking at testSolve in MagicAnimalCarousel.t.sol there is some complicated logic there, while it is enough to simply do

instance.changeAnimal("horse", 1);

because changeAnimal has a line encodedAnimal << 160 while it in fact should be encodedAnimal << 176.
Is this intended or I am missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@politicalnonconformist and others