Skip to content

Get state root from commitment - Signal Service #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeoPatOZ opened this issue Apr 3, 2025 · 0 comments
Open

Get state root from commitment - Signal Service #96

LeoPatOZ opened this issue Apr 3, 2025 · 0 comments
Labels
needs discussion This issue still needs discussion before implementing

Comments

@LeoPatOZ
Copy link
Collaborator

LeoPatOZ commented Apr 3, 2025

Currently the signal service relies on the commitment (stored in the commitment store) to be a state root, however in reality commitments might in fact be a block hash or a hash for two values (which might include the state root).

We have no mechanism to extract a state root in the case the commitment is something other than a state root, therefore our current implementation might not work.

I see two options:

  1. Make the verify signal function more generic as to what a commitment is, perhaps have a helper function to get the state root from the commitment (this might require additional info)
  2. Decide now what a commitment is, this might impact how we verify signals

I think i prefer option 1 so we can remain unopinionated as to what a commitment is although finding a generic impl might be hard.

@LeoPatOZ LeoPatOZ added the needs discussion This issue still needs discussion before implementing label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion This issue still needs discussion before implementing
Projects
None yet
Development

No branches or pull requests

1 participant