Skip to content

ServiceInsight may issue more HTTP requests to ServiceControl than necessary #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timbussmann opened this issue Jun 24, 2021 · 1 comment · Fixed by #1208
Closed

ServiceInsight may issue more HTTP requests to ServiceControl than necessary #1076

timbussmann opened this issue Jun 24, 2021 · 1 comment · Fixed by #1208
Labels
Milestone

Comments

@timbussmann
Copy link
Contributor

When selecting a message in the message list view, there are two "identic" HTTP requests going to the ServiceControl API to request the data.

This can be seen in the log view:
image

and it can also be seen on the code, that due to the call to SearchBar.NotifyPropertiesChanged(); both SequenceDiagramViewModel and MessageFlowViewModel are being triggered to create new requests.

Although the API call logic uses RestRequestWithCache, no If-None-Match headers are added to the request and the same ServiceControl controller is invoked twice.

@mauroservienti
Copy link
Member

This will be addressed by #1208

@mauroservienti mauroservienti added this to the 2.10.0 milestone Jun 23, 2022
@mauroservienti mauroservienti changed the title Selected message data is requested twice from ServiceControl ServiceInsight may issue more HTTP requests to ServiceControl than necessary Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants