Correct SecurityGateway to be global only (GoogleCloudPlatform#12788)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

Author: 2 people

mmv1/products/beyondcorp/SecurityGateway.yaml

@@ -48,10 +48,14 @@ autogen_status: U2VjdXJpdHlHYXRld2F5
 parameters:
   - name: location
     type: String
-    description: Resource ID segment making up resource `name`. It identifies the resource within its parent collection as described in https://google.aip.dev/122.
+    description: Resource ID segment making up resource `name`. It identifies the resource within its parent collection as described in https://google.aip.dev/122. Must be omitted or set to `global`.
+    deprecation_message: '`location` is deprecated and will be removed in a future major release.'
     immutable: true
     url_param_only: true
-    required: true
+    default_value: 'global'
+    validation:
+      regex: '^global$'
+    required: false
   - name: securityGatewayId
     type: String
     description: |-

mmv1/templates/terraform/examples/beyondcorp_security_gateway_basic.tf.tmpl

@@ -1,6 +1,5 @@
 resource "google_beyondcorp_security_gateway" "{{$.PrimaryResourceId}}" {
   security_gateway_id = "{{index $.Vars "security_gateway_name"}}"
-  location = "global"
   display_name = "My Security Gateway resource"
   hubs { region = "us-central1" }
 }

mmv1/third_party/terraform/services/beyondcorp/resource_beyondcorp_security_gateway_test.go

@@ -27,7 +27,7 @@ func TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_upda
 				ResourceName:            "google_beyondcorp_security_gateway.example",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"location", "security_gateway_id"},
+				ImportStateVerifyIgnore: []string{"security_gateway_id"},
 			},
 			{
 				Config: testAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update(context),
@@ -41,7 +41,7 @@ func TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_upda
 				ResourceName:            "google_beyondcorp_security_gateway.example",
 				ImportState:             true,
 				ImportStateVerify:       true,
-				ImportStateVerifyIgnore: []string{"location", "security_gateway_id"},
+				ImportStateVerifyIgnore: []string{"security_gateway_id"},
 			},
 		},
 	})
@@ -51,7 +51,6 @@ func testAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_basi
 	return acctest.Nprintf(`
 resource "google_beyondcorp_security_gateway" "example" {
   security_gateway_id = "default%{random_suffix}"
-  location = "global"
   display_name = "My Security Gateway resource"
   hubs { region = "us-central1" }
 }
@@ -62,7 +61,6 @@ func testAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_upda
 	return acctest.Nprintf(`
 resource "google_beyondcorp_security_gateway" "example" {
   security_gateway_id = "default%{random_suffix}"
-  location = "global"
   display_name = "My Security Gateway resource"
   hubs { region = "us-east1" }
 }