Public outbound ip (GoogleCloudPlatform#11675)

Author: prabhav2302

mmv1/products/alloydb/Instance.yaml

@@ -370,10 +370,22 @@ properties:
           Enabling public ip for the instance. If a user wishes to disable this,
           please also clear the list of the authorized external networks set on
           the same instance.
+      - !ruby/object:Api::Type::Boolean
+        name: enableOutboundPublicIp
+        description: |
+          Enabling outbound public ip for the instance.
   - !ruby/object:Api::Type::String
     name: 'publicIpAddress'
     output: true
     description: |
       The public IP addresses for the Instance. This is available ONLY when
       networkConfig.enablePublicIp is set to true. This is the connection
       endpoint for an end-user application.
+  - !ruby/object:Api::Type::Array
+    item_type: Api::Type::String
+    name: 'outboundPublicIpAddresses'
+    output: true
+    description: |
+      The outbound public IP addresses for the instance. This is available ONLY when
+      networkConfig.enableOutboundPublicIp is set to true. These IP addresses are used
+      for outbound connections.

mmv1/third_party/terraform/services/alloydb/resource_alloydb_instance_test.go

@@ -594,12 +594,15 @@ func TestAccAlloydbInstance_networkConfig(t *testing.T) {
 		"random_suffix":                suffix,
 		"network_name":                 networkName,
 		"enable_public_ip":             true,
+		"enable_outbound_public_ip":    true,
 		"authorized_external_networks": "",
 	}
+
 	context2 := map[string]interface{}{
-		"random_suffix":    suffix,
-		"network_name":     networkName,
-		"enable_public_ip": true,
+		"random_suffix":             suffix,
+		"network_name":              networkName,
+		"enable_public_ip":          true,
+		"enable_outbound_public_ip": false,
 		"authorized_external_networks": `
 		authorized_external_networks {
 			cidr_range = "8.8.8.8/30"
@@ -609,11 +612,13 @@ func TestAccAlloydbInstance_networkConfig(t *testing.T) {
 		}
 		`,
 	}
+
 	context3 := map[string]interface{}{
-		"random_suffix":    suffix,
-		"network_name":     networkName,
-		"enable_public_ip": true,
-		"cidr_range":       "8.8.8.8/30",
+		"random_suffix":             suffix,
+		"network_name":              networkName,
+		"enable_public_ip":          true,
+		"enable_outbound_public_ip": true,
+		"cidr_range":                "8.8.8.8/30",
 	}
 
 	acctest.VcrTest(t, resource.TestCase{
@@ -625,6 +630,8 @@ func TestAccAlloydbInstance_networkConfig(t *testing.T) {
 				Config: testAccAlloydbInstance_networkConfig(context1),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.enable_public_ip", "true"),
+					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.enable_outbound_public_ip", "true"),
+					resource.TestCheckResourceAttrSet("google_alloydb_instance.default", "outbound_public_ip_addresses.0"), // Ensure it's set
 				),
 			},
 			{
@@ -640,6 +647,8 @@ func TestAccAlloydbInstance_networkConfig(t *testing.T) {
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.authorized_external_networks.0.cidr_range", "8.8.8.8/30"),
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.authorized_external_networks.1.cidr_range", "8.8.4.4/30"),
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.authorized_external_networks.#", "2"),
+					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.enable_outbound_public_ip", "false"),
+					resource.TestCheckResourceAttr("google_alloydb_instance.default", "outbound_public_ip_addresses.#", "0"),
 				),
 			},
 			{
@@ -654,6 +663,8 @@ func TestAccAlloydbInstance_networkConfig(t *testing.T) {
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.enable_public_ip", "true"),
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.authorized_external_networks.0.cidr_range", "8.8.8.8/30"),
 					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.authorized_external_networks.#", "1"),
+					resource.TestCheckResourceAttr("google_alloydb_instance.default", "network_config.0.enable_outbound_public_ip", "true"),
+					resource.TestCheckResourceAttrSet("google_alloydb_instance.default", "outbound_public_ip_addresses.0"),
 				),
 			},
 			{
@@ -678,6 +689,7 @@ resource "google_alloydb_instance" "default" {
 
   network_config {
     enable_public_ip = %{enable_public_ip}
+    enable_outbound_public_ip = %{enable_outbound_public_ip}
     %{authorized_external_networks}
   }	
 }
@@ -713,6 +725,7 @@ resource "google_alloydb_instance" "default" {
 
   network_config {
     enable_public_ip = %{enable_public_ip}
+    enable_outbound_public_ip = %{enable_outbound_public_ip}
     authorized_external_networks {
       cidr_range = "%{cidr_range}"
     }