-
-
Notifications
You must be signed in to change notification settings - Fork 21
2 Bug Fixes + 1 Request #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
"--hidden" somewhere for the ".EXE" parameter might start it minimized in system tray |
This is the code the other RPC repository has for fixing poster images: phin05/discord-rich-presence-plex@50ac76d#diff-3070b9a832b66d17c3505e99e957d1288fea247a88983415ad66a163b9b1e8e4L9 The code's formatting looks to be different than the solution in this repository's other issue where the linked solution seems like the best process to fix poster images. Please use whichever process seems best to you though Hopefully these comments help |
This comment has been minimized.
This comment has been minimized.
Update:Some IMDB posters (which IMGUR shows for Discord's media preview) are in an aspect ratio of 2000 X 3000 (2:3). The smallest dimensions Jellyfin uses for media primary image is 680 X 1000 (17:25). Went through Discord documentation and found the following: Solution: If this repository's code changes to:
B) "Set Activity" shows information on the "Activity Object" which leads you to "Activity Assets" where you can find information on "Activity Asset Image" which ultimately explains "Image Formatting". For documentation purposes Discord states "The returned size can be changed by appending a querystring of ?size=desired_size to the URL. Image size can be any power of two between 16 and 4096." in case you prefer different dimensions to 1024 X 1024. If this is too much work or doesn't work you can submit a "Developer Support" Request and request if Discord can grant you similar RPC image properties to CrunchyRoll (might be best to save this image and upload it for a file attachment in the ticket since they might be weary on clicking links). |
Probably safest to default to resizing the Jellyfin retrieved image to 1024 H (and keeping the width scaled for the same ratio without stretching it) then having 171 pixels from each side transparent since 2:3 and 17:25 are pretty close. Less can go wrong by sticking with these values over dynamically resizing for aspect ratio. Worst case you lose 6.5 pixels on each side if having a 2:3 image for the preview |
Is there an existing issue for this?
Is your feature request related to a problem? Please describe
Bug 1: When enabling episode titles in the installer screen only the season and episode number display.
Bug 2: Discord shows image of media in a square format which cuts off aspect ratio.
Problem 1: Launching ".EXE" creates persistent terminal window on taskbar which doesn't start minimized.
Describe the solution you'd like
Bug Fix 1: When creating "main.js" from installer user prompt include the code to display episode title which is
Bug Fix 2: Reference comment here on formatting and Plex-RPC solution.
Request: Have the ".EXE" start minimized and in system tray (where the "^" is on the right of the taskbar) instead of on the taskbar. Current fix is to hide the terminal application in system tray when minimized however this is for every terminal instance instead of the ".EXE" only.
Looks like creating a GUI or something which isn't a terminal script would work (though how to code the system tray when minimized can't figure out). Creating a shortcut on the ".EXE" and launching the shortcut stops the ".EXE" from being a terminal window and launches minimized without popping up (with "Run" launch parameter of "Minimized") however don't know how to get the shortcut into system tray.
Please consider this request please and thank you.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: