Skip to content

Commit fa9df64

Browse files
committed
sea: expose only isExperimentalSeaWarningNeeded to JS from the binding
Refs: nodejs#47588 (comment) Signed-off-by: Darshan Sen <[email protected]>
1 parent ce5e999 commit fa9df64

File tree

2 files changed

+7
-13
lines changed

2 files changed

+7
-13
lines changed

lib/internal/main/embedding.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@ const {
33
prepareMainThreadExecution,
44
markBootstrapComplete,
55
} = require('internal/process/pre_execution');
6-
const { isExperimentalSeaWarningDisabled, isSea } = internalBinding('sea');
6+
const { isExperimentalSeaWarningNeeded } = internalBinding('sea');
77
const { emitExperimentalWarning } = require('internal/util');
88
const { embedderRequire, embedderRunCjs } = require('internal/util/embedding');
99
const { getEmbedderEntryFunction } = internalBinding('mksnapshot');
1010

1111
prepareMainThreadExecution(false, true);
1212
markBootstrapComplete();
1313

14-
if (isSea() && !isExperimentalSeaWarningDisabled()) {
14+
if (isExperimentalSeaWarningNeeded()) {
1515
emitExperimentalWarning('Single executable application');
1616
}
1717

src/node_sea.cc

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,9 @@ bool IsSingleExecutable() {
105105
return postject_has_resource();
106106
}
107107

108-
void IsSingleExecutable(const FunctionCallbackInfo<Value>& args) {
109-
args.GetReturnValue().Set(IsSingleExecutable());
110-
}
111-
112-
void IsExperimentalSeaWarningDisabled(const FunctionCallbackInfo<Value>& args) {
108+
void IsExperimentalSeaWarningNeeded(const FunctionCallbackInfo<Value>& args) {
113109
SeaResource sea_resource = FindSingleExecutableResource();
114-
args.GetReturnValue().Set(static_cast<bool>(
110+
args.GetReturnValue().Set(!static_cast<bool>(
115111
sea_resource.flags & SeaFlags::kDisableExperimentalSeaWarning));
116112
}
117113

@@ -243,16 +239,14 @@ void Initialize(Local<Object> target,
243239
Local<Value> unused,
244240
Local<Context> context,
245241
void* priv) {
246-
SetMethod(context, target, "isSea", IsSingleExecutable);
247242
SetMethod(context,
248243
target,
249-
"isExperimentalSeaWarningDisabled",
250-
IsExperimentalSeaWarningDisabled);
244+
"isExperimentalSeaWarningNeeded",
245+
IsExperimentalSeaWarningNeeded);
251246
}
252247

253248
void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
254-
registry->Register(IsSingleExecutable);
255-
registry->Register(IsExperimentalSeaWarningDisabled);
249+
registry->Register(IsExperimentalSeaWarningNeeded);
256250
}
257251

258252
} // namespace sea

0 commit comments

Comments
 (0)