Skip to content

Commit 0e57727

Browse files
MAINT: removing undesired comments
1 parent e55ddec commit 0e57727

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

docs/user/requirements.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ The following packages are needed in order to run RocketPy:
2727
- timezonefinder
2828
- simplekml
2929
- ipywidgets >= 7.6.3
30+
- jsonpickle
3031

3132

3233
All of these packages, with the exception of netCDF4, should be automatically installed when RocketPy is installed using either ``pip`` or ``conda``.

rocketpy/EnvironmentAnalysis.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
__license__ = "MIT"
66

77
import bisect
8-
import warnings
98
import json
9+
import warnings
1010
from collections import defaultdict
1111

1212
import ipywidgets as widgets
@@ -127,6 +127,7 @@ def __init__(
127127
self.__find_preferred_timezone()
128128
self.__localize_input_dates()
129129

130+
# Parse data files, surface goes first to calculate elevation
130131
self.surfaceDataDict = {}
131132
self.parseSurfaceData()
132133
self.pressureLevelDataDict = {}
@@ -589,7 +590,7 @@ def parsePressureLevelData(self):
589590
variablePointsArray = np.array([heightAboveSeaLevelArray, valueArray]).T
590591
variableFunction = Function(
591592
variablePointsArray,
592-
inputs="Height Above Ground Level (m)", # TODO: Check if it is really AGL or ASL here
593+
inputs="Height Above Ground Level (m)", # TODO: Check if it is really AGL or ASL here, see 3 lines above
593594
outputs=key,
594595
extrapolation="constant",
595596
)
@@ -856,8 +857,8 @@ def process_data(self):
856857
self.calculate_record_max_surface_100m_wind_speed()
857858
self.calculate_record_min_surface_100m_wind_speed()
858859
self.calculate_percentage_of_days_with_precipitation()
859-
self.calculate_average_cloud_base_height() # Having problems with masks!
860-
self.calculate_min_cloud_base_height() # Having problems with masks!
860+
self.calculate_average_cloud_base_height()
861+
self.calculate_min_cloud_base_height()
861862
self.calculate_percentage_of_days_with_no_cloud_coverage()
862863

863864
@property
@@ -2748,8 +2749,6 @@ def exportMeanProfiles(self, filename="export_env_analysis"):
27482749
# "maxExpectedHeight": 80000, # TODO: Implement this parameter at EnvAnalysis Class
27492750
"surfaceDataFile": self.surfaceDataFile,
27502751
"pressureLevelDataFile": self.pressureLevelDataFile,
2751-
# "surfaceDataDict": self.surfaceDataDict, # TODO: Too large, make it optional
2752-
# "pressureLevelDataDict": self.pressureLevelDataDict, # TODO: Too large, make it optional
27532752
"atmosphericModelPressureProfile": organized_pressure_dict,
27542753
"atmosphericModelTemperatureProfile": organized_temperature_dict,
27552754
"atmosphericModelWindVelocityXProfile": organized_windX_dict,

0 commit comments

Comments
 (0)