-
Notifications
You must be signed in to change notification settings - Fork 102
[VariantItem]:[Add support for icon] #6990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Mohit83333 this feature is not covered by our global UX guidelines, so, for this to be implemented the request would need to go through the Inner Source process and be synchronised with the SAP Central Design team first. Please raise a BLI to the central design team and include the ticket number here for reference.
We can only downport bug fixes, not features since this would (i.a.) violate semantic versioning. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Inactive issues will be closed after 7 days. Thanks. |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please first check to see if the maintainers have requested additional input and provide it if necessary, or post a detailed description of why this issue is still a problem. |
Hi, Post was edited by @Lukas742. Reason: removed internal link |
Is your feature request related to a problem?
There is requirement to introduce an icon for subcomponent VariantItem which is used as part of component VariantManagement . This icon is needed to differentiate between VariantItems in the popover. As of now the variantItem only accepts string as its children.
For more clarity screenshot is attached in below section.
Describe the solution you'd like
As of now the variantItem only accepts string as its children. if this could be changed to react node or some other feasible solution so that custom data can be added to it.
Describe alternatives you've considered
Expectations are somewhat similar to ListItemCustom - A component to be used as custom list item within the List component. Similarly if there is an option for VariantItemCustom with VariantManagement component which user can provide custom attributes as per requirement.
Additional Context
Required for version 2 and version 1
Organization
SAP
Declaration
The text was updated successfully, but these errors were encountered: