Skip to content

Commit 6693ecb

Browse files
committed
Added the test case testEncodingGrayscaleImage about grayscale
1 parent cab8cd9 commit 6693ecb

File tree

3 files changed

+33
-0
lines changed

3 files changed

+33
-0
lines changed

Tests/Images/TestImageGrayscale.jpg

1.27 MB
Loading

Tests/SDWebImageWebPCoderTests.m

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,35 @@ - (void)testEncodingSettingsIncorrectType {
292292
expect(config.method).to.equal(4);
293293
}
294294

295+
296+
- (void)testEncodingGrayscaleImage {
297+
NSURL *grayscaleImageURL = [[NSBundle bundleForClass:[self class]] URLForResource:@"TestImageGrayscale" withExtension:@"jpg"];
298+
NSData *grayscaleImageData = [NSData dataWithContentsOfURL:grayscaleImageURL];
299+
UIImage *grayscaleImage = [[UIImage alloc] initWithData:grayscaleImageData];
300+
expect(grayscaleImage).notTo.beNil();
301+
302+
NSData *webpData = [SDImageWebPCoder.sharedCoder encodedDataWithImage:grayscaleImage format:SDImageFormatWebP options:nil];
303+
expect(webpData).notTo.beNil();
304+
305+
UIImage *decodedImage = [UIImage sd_imageWithData:webpData];
306+
expect(decodedImage).notTo.beNil();
307+
308+
// Sample to verify that encoded WebP image's color is correct.
309+
// The wrong case before bugfix is that each column color will repeats 3 times.
310+
CGPoint point1 = CGPointMake(271, 764);
311+
CGPoint point2 = CGPointMake(round(point1.x + decodedImage.size.width / 3), point1.y);
312+
UIColor *color1 = [decodedImage sd_colorAtPoint:point1];
313+
UIColor *color2 = [decodedImage sd_colorAtPoint:point2];
314+
CGFloat r1, r2;
315+
CGFloat g1, g2;
316+
CGFloat b1, b2;
317+
[color1 getRed:&r1 green:&g1 blue:&b1 alpha:nil];
318+
[color2 getRed:&r2 green:&g2 blue:&b2 alpha:nil];
319+
expect(255 * r1).notTo.equal(255 * r2);
320+
expect(255 * g1).notTo.equal(255 * g2);
321+
expect(255 * b1).notTo.equal(255 * b2);
322+
}
323+
295324
@end
296325

297326
@implementation SDWebImageWebPCoderTests (Helpers)

Tests/SDWebImageWebPCoderTests.xcodeproj/project.pbxproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
/* Begin PBXBuildFile section */
1010
0EF5B6264833B7BC20894578 /* Pods_SDWebImageWebPCoderTests.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 46F21AD7D1692EBAC4D0FF33 /* Pods_SDWebImageWebPCoderTests.framework */; };
1111
3219F3B2228B0453003822A6 /* TestImageBlendAnimated.webp in Resources */ = {isa = PBXBuildFile; fileRef = 3219F3B1228B0453003822A6 /* TestImageBlendAnimated.webp */; };
12+
325E268E25C82BE1000B807B /* TestImageGrayscale.jpg in Resources */ = {isa = PBXBuildFile; fileRef = 325E268D25C82BE1000B807B /* TestImageGrayscale.jpg */; };
1213
808C918E213FD131004B0F7C /* SDWebImageWebPCoderTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 808C918D213FD131004B0F7C /* SDWebImageWebPCoderTests.m */; };
1314
808C919C213FD2B2004B0F7C /* TestImageStatic.webp in Resources */ = {isa = PBXBuildFile; fileRef = 808C919A213FD2B2004B0F7C /* TestImageStatic.webp */; };
1415
808C919D213FD2B2004B0F7C /* TestImageAnimated.webp in Resources */ = {isa = PBXBuildFile; fileRef = 808C919B213FD2B2004B0F7C /* TestImageAnimated.webp */; };
@@ -17,6 +18,7 @@
1718
/* Begin PBXFileReference section */
1819
28D8AA3D3015E075692FD3E3 /* Pods-SDWebImageWebPCoderTests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SDWebImageWebPCoderTests.debug.xcconfig"; path = "../Pods/Target Support Files/Pods-SDWebImageWebPCoderTests/Pods-SDWebImageWebPCoderTests.debug.xcconfig"; sourceTree = "<group>"; };
1920
3219F3B1228B0453003822A6 /* TestImageBlendAnimated.webp */ = {isa = PBXFileReference; lastKnownFileType = file; path = TestImageBlendAnimated.webp; sourceTree = "<group>"; };
21+
325E268D25C82BE1000B807B /* TestImageGrayscale.jpg */ = {isa = PBXFileReference; lastKnownFileType = image.jpeg; path = TestImageGrayscale.jpg; sourceTree = "<group>"; };
2022
46F21AD7D1692EBAC4D0FF33 /* Pods_SDWebImageWebPCoderTests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SDWebImageWebPCoderTests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
2123
808C918B213FD130004B0F7C /* SDWebImageWebPCoderTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = SDWebImageWebPCoderTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
2224
808C918D213FD131004B0F7C /* SDWebImageWebPCoderTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = SDWebImageWebPCoderTests.m; sourceTree = "<group>"; };
@@ -78,6 +80,7 @@
7880
808C9199213FD2B2004B0F7C /* Images */ = {
7981
isa = PBXGroup;
8082
children = (
83+
325E268D25C82BE1000B807B /* TestImageGrayscale.jpg */,
8184
808C919A213FD2B2004B0F7C /* TestImageStatic.webp */,
8285
808C919B213FD2B2004B0F7C /* TestImageAnimated.webp */,
8386
3219F3B1228B0453003822A6 /* TestImageBlendAnimated.webp */,
@@ -154,6 +157,7 @@
154157
3219F3B2228B0453003822A6 /* TestImageBlendAnimated.webp in Resources */,
155158
808C919D213FD2B2004B0F7C /* TestImageAnimated.webp in Resources */,
156159
808C919C213FD2B2004B0F7C /* TestImageStatic.webp in Resources */,
160+
325E268E25C82BE1000B807B /* TestImageGrayscale.jpg in Resources */,
157161
);
158162
runOnlyForDeploymentPostprocessing = 0;
159163
};

0 commit comments

Comments
 (0)