Skip to content

Commit 04a719a

Browse files
awharrison-28SOE-YoungS
authored andcommitted
Python: Fix integration test check for PRs (microsoft#2490)
### Motivation and Context Python integration test check resolves the MSTEAM_WEBHOOK as "" when run for PRs. The secret is not needed in this scenario, but the value should be non "" ### Description ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
1 parent 6df8464 commit 04a719a

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

.github/workflows/python-integration-tests.yml

+11-1
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,20 @@ jobs:
183183

184184
- name: Microsoft Teams Notification
185185
uses: skitionek/notify-microsoft-teams@master
186-
if: always()
186+
if: github.ref == 'refs/heads/main'
187187
with:
188188
webhook_url: ${{ secrets.MSTEAMS_WEBHOOK }}
189189
dry_run: ${{ env.run_type != 'Daily' && env.run_type != 'Manual'}}
190190
job: ${{ toJson(job) }}
191191
steps: ${{ toJson(steps) }}
192192
overwrite: "{title: ` ${{ env.run_type }}: ${{ env.date }} `, text: ` ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}`}"
193+
194+
- name: Microsoft Teams Notification (Dry Run)
195+
uses: skitionek/notify-microsoft-teams@master
196+
if: github.ref != 'refs/heads/main'
197+
with:
198+
webhook_url: NONE
199+
dry_run: ${{ env.run_type != 'Daily' && env.run_type != 'Manual'}}
200+
job: ${{ toJson(job) }}
201+
steps: ${{ toJson(steps) }}
202+
overwrite: "{title: ` ${{ env.run_type }}: ${{ env.date }} `, text: ` ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}`}"

0 commit comments

Comments
 (0)