Skip to content

Commit 3817caf

Browse files
awharrison-28lemillermicrosoft
authored andcommitted
Python: Integration tests 'needs' path filter job (microsoft#2557)
### Motivation and Context PRs microsoft#2533 and microsoft#2555 updated the integration tests to trigger off of python changes only, but did not actually have the resulting jobs require the path filtering. This means that the tests never run. ### Description Add path-filter job as a requirement for subsequent jobs. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 --------- Co-authored-by: Lee Miller <[email protected]>
1 parent 42c6151 commit 3817caf

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/python-integration-tests.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ jobs:
3939
run: echo "NOT python file"
4040

4141
python-merge-gate:
42+
needs: paths-filter
4243
if: github.event_name != 'pull_request' && github.event_name != 'schedule' && needs.paths-filter.outputs.pythonChanges == 'true'
4344
runs-on: ${{ matrix.os }}
4445
strategy:
@@ -66,7 +67,7 @@ jobs:
6667
python -m pip install --upgrade pip setuptools wheel
6768
python -m pip install poetry pytest
6869
cd python
69-
poetry install --without azure_cognitive_search --without weaviate --without pinecone --without postgres
70+
poetry install
7071
- name: Run Integration Tests
7172
id: run_tests
7273
shell: bash
@@ -94,6 +95,7 @@ jobs:
9495
poetry run pytest ./tests/integration -v
9596
9697
python-integration-tests:
98+
needs: paths-filter
9799
if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && needs.paths-filter.outputs.pythonChanges == 'true'
98100
runs-on: ${{ matrix.os }}
99101
strategy:

python/samples/kernel-syntax-examples/action_planner.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ async def main():
1313
api_key, org_id = sk.openai_settings_from_dot_env()
1414

1515
kernel.add_chat_service(
16-
"gpt-3.5", OpenAIChatCompletion("gpt-3.5-turbo", api_key, org_id)
16+
"chat-gpt", OpenAIChatCompletion("gpt-3.5-turbo", api_key, org_id)
1717
)
1818
kernel.import_skill(MathSkill(), "math")
1919
kernel.import_skill(FileIOSkill(), "fileIO")

0 commit comments

Comments
 (0)