Merge pull request #453 from iceljc/bugfix/fix-truncate-breakpoint

fix truncate breakpoint

Author: Oceania2018

src/Infrastructure/BotSharp.Abstraction/Conversations/IConversationStateService.cs

@@ -17,6 +17,6 @@ IConversationStateService SetState<T>(string name, T value, bool isNeedVersion =
         int activeRounds = -1, string valueType = StateDataType.String, string source = StateSource.User, bool readOnly = false);
     void SaveStateByArgs(JsonDocument args);
     bool RemoveState(string name);
-    void CleanStates(params string[] keepStates);
+    void CleanStates(params string[] excludedStates);
     void Save();
 }

src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationStateService.cs

@@ -270,7 +270,7 @@ public bool RemoveState(string name)
         return true;
     }
 
-    public void CleanStates(params string[] keepStates)
+    public void CleanStates(params string[] excludedStates)
     {
         var routingCtx = _services.GetRequiredService<IRoutingContext>();
         var curMsgId = routingCtx.MessageId;
@@ -279,7 +279,7 @@ public void CleanStates(params string[] keepStates)
         foreach (var key in _curStates.Keys)
         {
             // skip state
-            if (keepStates.Contains(key))
+            if (excludedStates.Contains(key))
             {
                 continue;
             }

src/Infrastructure/BotSharp.Core/Repository/FileRepository/FileRepository.Conversation.cs

@@ -481,7 +481,7 @@ public IEnumerable<string> TruncateConversation(string conversationId, string me
             // Handle truncated breakpoints
             var breakpointDir = Path.Combine(convDir, BREAKPOINT_FILE);
             var breakpoints = CollectConversationBreakpoints(breakpointDir);
-            isSaved = HandleTruncatedBreakpoints(breakpointDir, breakpoints, messageId);
+            isSaved = HandleTruncatedBreakpoints(breakpointDir, breakpoints, refTime);
 
             // Remove logs
             if (cleanLog)
@@ -585,10 +585,9 @@ private bool HandleTruncatedStates(string stateDir, List<StateKeyValue> states,
             return isSaved;
         }
 
-        private bool HandleTruncatedBreakpoints(string breakpointDir, List<ConversationBreakpoint> breakpoints, string refMessageId)
+        private bool HandleTruncatedBreakpoints(string breakpointDir, List<ConversationBreakpoint> breakpoints, DateTime refTime)
         {
-            var targetIdx = breakpoints.FindIndex(x => x.MessageId == refMessageId);
-            var truncatedBreakpoints = breakpoints?.Where((x, idx) => idx < targetIdx)?
+            var truncatedBreakpoints = breakpoints?.Where(x => x.CreatedTime < refTime)?
                                                    .ToList() ?? new List<ConversationBreakpoint>();
 
             var isSaved = SaveTruncatedBreakpoints(breakpointDir, truncatedBreakpoints);

src/Plugins/BotSharp.Plugin.MongoStorage/Repository/MongoRepository.Conversation.cs

@@ -452,8 +452,7 @@ public IEnumerable<string> TruncateConversation(string conversationId, string me
             if (!foundStates.Breakpoints.IsNullOrEmpty())
             {
                 var breakpoints = foundStates.Breakpoints ?? new List<BreakpointMongoElement>();
-                var targetIdx = breakpoints.FindIndex(x => x.MessageId == messageId);
-                var truncatedBreakpoints = breakpoints.Where((x, idx) => idx < targetIdx).ToList();
+                var truncatedBreakpoints = breakpoints.Where(x => x.CreatedTime < refTime).ToList();
                 foundStates.Breakpoints = truncatedBreakpoints;
             }