Skip to content

Commit a043b84

Browse files
authored
Merge pull request #406 from iceljc/features/refine-agent-refresh
add log in agent refresh
2 parents 5380ecb + 2af4102 commit a043b84

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.RefreshAgents.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,12 @@ public async Task<string> RefreshAgents()
5151
var isAgentDeleted = _db.DeleteAgent(agent.Id);
5252
if (isAgentDeleted)
5353
{
54+
await Task.Delay(100);
5455
_db.BulkInsertAgents(new List<Agent> { agent });
5556
_db.BulkInsertUserAgents(new List<UserAgent> { userAgent });
5657
_db.BulkInsertAgentTasks(tasks);
5758
refreshedAgents.Add(agent.Name);
59+
_logger.LogInformation($"Agent {agent.Name} has been migrated.");
5860
}
5961
}
6062
catch (Exception ex)
@@ -66,7 +68,7 @@ public async Task<string> RefreshAgents()
6668
if (!refreshedAgents.IsNullOrEmpty())
6769
{
6870
Utilities.ClearCache();
69-
refreshResult = $"Agents are migrated! {string.Join("\r\n", refreshedAgents)}";
71+
refreshResult = $"Agents are migrated!\r\n{string.Join("\r\n", refreshedAgents)}";
7072
}
7173
else
7274
{

src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.UpdateAgent.cs

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,13 @@ public async Task UpdateAgent(Agent agent, AgentField updateField)
4141

4242
public async Task<string> UpdateAgentFromFile(string id)
4343
{
44+
string updateResult;
4445
var agent = _db.GetAgent(id);
4546
if (agent == null)
4647
{
47-
return $"Cannot find agent ${id}";
48+
updateResult = $"Cannot find agent ${id}";
49+
_logger.LogError(updateResult);
50+
return updateResult;
4851
}
4952

5053
var dbSettings = _services.GetRequiredService<BotSharpDatabaseSettings>();
@@ -57,7 +60,9 @@ public async Task<string> UpdateAgentFromFile(string id)
5760
var foundAgent = FetchAgentFileById(agent.Id, filePath);
5861
if (foundAgent == null)
5962
{
60-
return $"Cannot find agent {agent.Name} in file directory: {filePath}";
63+
updateResult = $"Cannot find agent {agent.Name} in file directory: {filePath}";
64+
_logger.LogError(updateResult);
65+
return updateResult;
6166
}
6267

6368
try
@@ -79,11 +84,16 @@ public async Task<string> UpdateAgentFromFile(string id)
7984

8085
_db.UpdateAgent(clonedAgent, AgentField.All);
8186
Utilities.ClearCache();
82-
return $"Agent {agent.Name} has been migrated!";
87+
88+
updateResult = $"Agent {agent.Name} has been migrated!";
89+
_logger.LogInformation(updateResult);
90+
return updateResult;
8391
}
8492
catch (Exception ex)
8593
{
86-
return $"Failed to migrate agent {agent.Name} in file directory {filePath}.\r\nError: {ex.Message}";
94+
updateResult = $"Failed to migrate agent {agent.Name} in file directory {filePath}.\r\nError: {ex.Message}";
95+
_logger.LogError(updateResult);
96+
return updateResult;
8797
}
8898
}
8999

0 commit comments

Comments
 (0)