Skip to content

Should we check optional dependency licenses #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mauicv opened this issue Jul 25, 2022 · 1 comment
Closed

Should we check optional dependency licenses #568

mauicv opened this issue Jul 25, 2022 · 1 comment
Labels
Type: Question User questions

Comments

@mauicv
Copy link
Contributor

mauicv commented Jul 25, 2022

The prophet optional dependency in Alibi-Detect currently has two dependencies: pystan and PyMeeus (via fbprophet) both of which are under "GNU General Public License v3 (GPLv3)" license. They weren't coming up with prior license checks because the script that checks the licenses uses extras=all in the tox-env settings but there is no all optional dependency option by default for pip installs instead it just gives a warning which I think is silenced in CI. Now that the all option has been added for the optional dependencies work, they've turned up. To retain current behaviour I've removed extras=all for the licenses in the setup.cfg so license checks don't run for optional dependencies.

Because these are optional dependencies this isn't really an issue but it raises the question of how we should be checking the licenses? i.e. do we look at all the dependencies or just the defaults? If we check all we should flag those that are optional so we know how much of an issue it is, etc...

@mauicv mauicv added the Type: Question User questions label Jul 25, 2022
@jklaise
Copy link
Contributor

jklaise commented Jul 25, 2022

Happy to stick with defaults as the checks are more to see whether there have been any changed to licences of core dependencies that you can run the library with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question User questions
Projects
None yet
Development

No branches or pull requests

3 participants