Skip to content

Commit 3dbf71d

Browse files
committed
[java] Fixing minor issues reported by IDEA code linter
1 parent c87ee59 commit 3dbf71d

File tree

6 files changed

+12
-15
lines changed

6 files changed

+12
-15
lines changed

java/client/src/org/openqa/selenium/MutableCapabilities.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -202,24 +202,24 @@ private String abbreviate(Map<Object, String> seen, Object stringify) {
202202
if (stringify.getClass().isArray()) {
203203
value.append("[");
204204
value.append(
205-
Stream.of((Object[]) stringify)
206-
.map(item -> abbreviate(seen, item))
207-
.collect(Collectors.joining(", ")));
205+
Stream.of((Object[]) stringify)
206+
.map(item -> abbreviate(seen, item))
207+
.collect(Collectors.joining(", ")));
208208
value.append("]");
209209
} else if (stringify instanceof Collection) {
210210
value.append("[");
211211
value.append(
212-
((Collection<?>) stringify).stream()
213-
.map(item -> abbreviate(seen, item))
214-
.collect(Collectors.joining(", ")));
212+
((Collection<?>) stringify).stream()
213+
.map(item -> abbreviate(seen, item))
214+
.collect(Collectors.joining(", ")));
215215
value.append("]");
216216
} else if (stringify instanceof Map) {
217217
value.append("{");
218218
value.append(
219-
((Map<?, ?>) stringify).entrySet().stream()
220-
.sorted(Comparator.comparing(entry -> String.valueOf(entry.getKey())))
221-
.map(entry -> String.valueOf(entry.getKey()) + ": " + abbreviate(seen, entry.getValue()))
222-
.collect(Collectors.joining(", ")));
219+
((Map<?, ?>) stringify).entrySet().stream()
220+
.sorted(Comparator.comparing(entry -> String.valueOf(entry.getKey())))
221+
.map(entry -> String.format("%s: %s", entry.getKey(), abbreviate(seen, entry.getValue())))
222+
.collect(Collectors.joining(", ")));
223223
value.append("}");
224224
} else {
225225
String s = String.valueOf(stringify);

java/client/src/org/openqa/selenium/json/JsonType.java

-1
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,4 @@ public enum JsonType {
2828
END_COLLECTION,
2929
STRING,
3030
END
31-
;
3231
}

java/client/src/org/openqa/selenium/json/PropertySetting.java

-1
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,4 @@
2020
public enum PropertySetting {
2121
BY_NAME,
2222
BY_FIELD
23-
;
2423
}

java/client/src/org/openqa/selenium/net/UrlChecker.java

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import java.net.HttpURLConnection;
2222
import java.net.URL;
2323
import java.util.Arrays;
24-
import java.util.concurrent.Callable;
2524
import java.util.concurrent.ExecutionException;
2625
import java.util.concurrent.ExecutorService;
2726
import java.util.concurrent.Executors;

java/client/src/org/openqa/selenium/remote/codec/w3c/W3CHttpCommandCodec.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@ private Map<String, String> asElement(Object id) {
435435
private String cssEscape(String using) {
436436
using = using.replaceAll("([\\s'\"\\\\#.:;,!?+<>=~*^$|%&@`{}\\-\\/\\[\\]\\(\\)])", "\\\\$1");
437437
if (using.length() > 0 && Character.isDigit(using.charAt(0))) {
438-
using = "\\" + Integer.toString(30 + Integer.parseInt(using.substring(0,1))) + " " + using.substring(1);
438+
using = "\\" + (30 + Integer.parseInt(using.substring(0,1))) + " " + using.substring(1);
439439
}
440440
return using;
441441
}

java/client/src/org/openqa/selenium/remote/tracing/Span.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ enum Kind {
4646
// The nice name is the name expected in an OT trace.
4747
private final String niceName;
4848

49-
private Kind(String niceName) {
49+
Kind(String niceName) {
5050
this.niceName = niceName;
5151
}
5252

0 commit comments

Comments
 (0)