Skip to content

Commit 679670b

Browse files
committed
Allow Netty AppServer to respond to HEAD requests
1 parent f9e8ce2 commit 679670b

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

java/server/src/org/openqa/selenium/netty/server/RequestConverter.java

+10-5
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import java.util.concurrent.Executors;
4646
import java.util.logging.Logger;
4747

48+
import static io.netty.handler.codec.http.HttpMethod.HEAD;
4849
import static org.openqa.selenium.remote.http.Contents.memoize;
4950

5051
class RequestConverter extends SimpleChannelInboundHandler<HttpObject> {
@@ -126,11 +127,15 @@ private HttpRequest createRequest(
126127

127128
// Attempt to map the netty method
128129
HttpMethod method;
129-
try {
130-
method = HttpMethod.valueOf(nettyRequest.method().name());
131-
} catch (IllegalArgumentException e) {
132-
ctx.writeAndFlush(new DefaultFullHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.METHOD_NOT_ALLOWED));
133-
return null;
130+
if (nettyRequest.method().equals(HEAD)) {
131+
method = HttpMethod.GET;
132+
} else {
133+
try {
134+
method = HttpMethod.valueOf(nettyRequest.method().name());
135+
} catch (IllegalArgumentException e) {
136+
ctx.writeAndFlush(new DefaultFullHttpResponse(HttpVersion.HTTP_1_1, HttpResponseStatus.METHOD_NOT_ALLOWED));
137+
return null;
138+
}
134139
}
135140

136141
QueryStringDecoder decoder = new QueryStringDecoder(nettyRequest.uri());

0 commit comments

Comments
 (0)