[rb] move print functionality into driver extension

Author: titusfortner

rb/lib/selenium/webdriver/chrome/driver.rb

@@ -34,6 +34,7 @@ class Driver < WebDriver::Driver
         include DriverExtensions::HasDevTools
         include DriverExtensions::HasAuthentication
         include DriverExtensions::HasLogEvents
+        include DriverExtensions::PrintsPage
 
         def browser
           :chrome
@@ -47,12 +48,6 @@ def execute_cdp(cmd, **params)
           @bridge.send_command(cmd: cmd, params: params)
         end
 
-        def print_page(**options)
-          options[:page_ranges] &&= Array(options[:page_ranges])
-
-          @bridge.print_page(options)
-        end
-
         private
 
         def debugger_address

rb/lib/selenium/webdriver/common.rb

@@ -60,6 +60,7 @@
 require 'selenium/webdriver/common/driver_extensions/has_network_connection'
 require 'selenium/webdriver/common/driver_extensions/has_permissions'
 require 'selenium/webdriver/common/driver_extensions/has_debugger'
+require 'selenium/webdriver/common/driver_extensions/prints_page'
 require 'selenium/webdriver/common/driver_extensions/uploads_files'
 require 'selenium/webdriver/common/driver_extensions/has_addons'
 require 'selenium/webdriver/common/driver_extensions/has_devtools'

rb/lib/selenium/webdriver/common/driver_extensions/prints_page.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+module Selenium
+  module WebDriver
+    module DriverExtensions
+      module PrintsPage
+        def print_page(**options)
+          options[:page_ranges] &&= Array(options[:page_ranges])
+
+          @bridge.print_page(options)
+        end
+      end # PrintsPage
+    end # DriverExtensions
+  end # WebDriver
+end # Selenium

rb/lib/selenium/webdriver/firefox/driver.rb

@@ -29,6 +29,7 @@ module Firefox
       class Driver < WebDriver::Driver
         include DriverExtensions::HasAddons
         include DriverExtensions::HasWebStorage
+        include DriverExtensions::PrintsPage
 
         def browser
           :firefox
@@ -37,12 +38,6 @@ def browser
         def bridge_class
           Bridge
         end
-
-        def print_page(**options)
-          options[:page_ranges] &&= Array(options[:page_ranges])
-
-          @bridge.print_page(options)
-        end
       end # Driver
     end # Firefox
   end # WebDriver