Skip to content

Commit 8e09e76

Browse files
committed
[grid] Closing http client when a session is complete. Fixes #9153
1 parent ec807f8 commit 8e09e76

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

java/client/src/org/openqa/selenium/remote/tracing/TracedHttpClient.java

+6
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import org.openqa.selenium.remote.http.HttpResponse;
3030
import org.openqa.selenium.remote.http.WebSocket;
3131

32+
import java.io.IOException;
3233
import java.net.URL;
3334

3435
public class TracedHttpClient implements HttpClient {
@@ -58,6 +59,11 @@ public HttpResponse execute(HttpRequest req) {
5859
}
5960
}
6061

62+
@Override
63+
public void close() throws IOException {
64+
delegate.close();
65+
}
66+
6167
public static class Factory implements HttpClient.Factory {
6268

6369
private final Tracer tracer;

java/server/src/org/openqa/selenium/grid/node/config/DriverServiceSessionFactory.java

+7
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@
4242
import org.openqa.selenium.remote.tracing.Status;
4343
import org.openqa.selenium.remote.tracing.Tracer;
4444

45+
import java.io.IOException;
46+
import java.io.UncheckedIOException;
4547
import java.net.URI;
4648
import java.net.URL;
4749
import java.time.Instant;
@@ -152,6 +154,11 @@ public Optional<ActiveSession> apply(CreateSessionRequest sessionRequest) {
152154
@Override
153155
public void stop() {
154156
service.stop();
157+
try {
158+
client.close();
159+
} catch (IOException e) {
160+
throw new UncheckedIOException(e);
161+
}
155162
}
156163
});
157164
} catch (Exception e) {

0 commit comments

Comments
 (0)