Skip to content

Commit 9492ee6

Browse files
committed
Move .NET CDP generation targets to list
1 parent d2b483c commit 9492ee6

File tree

2 files changed

+14
-21
lines changed

2 files changed

+14
-21
lines changed

dotnet/defs.bzl

+7
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ load("//dotnet/private:generate_devtools.bzl", _generate_devtools = "generate_de
44
load("//dotnet/private:merge_assemblies.bzl", _merged_assembly = "merged_assembly")
55
load("//dotnet/private:nuget.bzl", _nuget_package = "nuget_package", _nuget_push = "nuget_push")
66
load("//dotnet/private:nunit_test.bzl", _nunit_test = "nunit_test")
7+
load("//dotnet:selenium-dotnet-version.bzl", "SUPPORTED_DEVTOOLS_VERSIONS")
8+
9+
def devtools_version_targets():
10+
targets = []
11+
for devtools_version in SUPPORTED_DEVTOOLS_VERSIONS:
12+
targets.append("//dotnet/src/webdriver/cdp:generate-{}".format(devtools_version))
13+
return targets
714

815
generated_assembly_info = _generated_assembly_info
916
csharp_executable = _csharp_executable

dotnet/src/webdriver/BUILD.bazel

+7-21
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ load(
55
"merged_assembly",
66
"generated_assembly_info",
77
"nuget_package",
8-
"nuget_push")
8+
"nuget_push",
9+
"devtools_version_targets",)
910
load(
1011
"//dotnet:selenium-dotnet-version.bzl",
1112
"ASSEMBLY_COMPANY",
@@ -16,6 +17,7 @@ load(
1617
"SE_VERSION",
1718
"SUPPORTED_NET_FRAMEWORKS",
1819
"SUPPORTED_NET_STANDARD_VERSIONS",
20+
"SUPPORTED_DEVTOOLS_VERSIONS",
1921
)
2022

2123
generated_assembly_info(
@@ -48,11 +50,7 @@ generated_assembly_info(
4850
"Support/*.cs",
4951
]) + [
5052
":assembly-info",
51-
"//dotnet/src/webdriver/cdp:generate-v84",
52-
"//dotnet/src/webdriver/cdp:generate-v85",
53-
"//dotnet/src/webdriver/cdp:generate-v86",
54-
"//dotnet/src/webdriver/cdp:generate-v87",
55-
],
53+
] + devtools_version_targets(),
5654
out = "WebDriver",
5755
resources = [
5856
"//javascript/atoms/fragments:find-elements.js",
@@ -97,11 +95,7 @@ generated_assembly_info(
9795
"Support/*.cs",
9896
]) + [
9997
":assembly-info",
100-
"//dotnet/src/webdriver/cdp:generate-v84",
101-
"//dotnet/src/webdriver/cdp:generate-v85",
102-
"//dotnet/src/webdriver/cdp:generate-v86",
103-
"//dotnet/src/webdriver/cdp:generate-v87",
104-
],
98+
] + devtools_version_targets(),
10599
out = "WebDriver",
106100
resources = [
107101
"//javascript/atoms/fragments:find-elements.js",
@@ -137,11 +131,7 @@ generated_assembly_info(
137131
"Support/*.cs",
138132
]) + [
139133
":assembly-info",
140-
"//dotnet/src/webdriver/cdp:generate-v84",
141-
"//dotnet/src/webdriver/cdp:generate-v85",
142-
"//dotnet/src/webdriver/cdp:generate-v86",
143-
"//dotnet/src/webdriver/cdp:generate-v87",
144-
],
134+
] + devtools_version_targets(),
145135
out = "strongnamed/WebDriver",
146136
keyfile = "//dotnet:WebDriver.snk",
147137
resources = [
@@ -187,11 +177,7 @@ generated_assembly_info(
187177
"Support/*.cs",
188178
]) + [
189179
":assembly-info",
190-
"//dotnet/src/webdriver/cdp:generate-v84",
191-
"//dotnet/src/webdriver/cdp:generate-v85",
192-
"//dotnet/src/webdriver/cdp:generate-v86",
193-
"//dotnet/src/webdriver/cdp:generate-v87",
194-
],
180+
] + devtools_version_targets(),
195181
out = "strongnamed/WebDriver",
196182
keyfile = "//dotnet:WebDriver.snk",
197183
resources = [

0 commit comments

Comments
 (0)