feat: Add remaining nullable markers

Author: nikcio

src/Examine.Core/Search/FacetResult.cs

@@ -1,5 +1,6 @@
 using System.Collections;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 
 namespace Examine.Search
@@ -8,7 +9,12 @@ namespace Examine.Search
     public class FacetResult : IFacetResult
     {
         private readonly IEnumerable<IFacetValue> _values;
+#if NETSTANDARD2_1
+        [AllowNull]
         private IDictionary<string, IFacetValue> _dictValues;
+#else
+        private IDictionary<string, IFacetValue>? _dictValues;
+#endif
 
         /// <inheritdoc/>
         public FacetResult(IEnumerable<IFacetValue> values)
@@ -22,6 +28,9 @@ public IEnumerator<IFacetValue> GetEnumerator()
             return _values.GetEnumerator();
         }
 
+#if !NETSTANDARD2_0 && !NETSTANDARD2_1
+        [MemberNotNull(nameof(_dictValues))]
+#endif
         private void SetValuesDictionary()
         {
             if(_dictValues == null)
@@ -38,7 +47,7 @@ private void SetValuesDictionary()
         }
 
         /// <inheritdoc/>
-        public bool TryGetFacet(string label, out IFacetValue facetValue)
+        public bool TryGetFacet(string label, out IFacetValue? facetValue)
         {
             SetValuesDictionary();
             return _dictValues.TryGetValue(label, out facetValue);

src/Examine.Core/Search/IFacetOperations.cs

@@ -14,7 +14,7 @@ public interface IFacetOperations : IQueryExecutor
         /// <param name="field"></param>
         /// <param name="facetConfiguration"></param>
         /// <returns></returns>
-        IFacetOperations Facet(string field, Action<IFacetQueryField> facetConfiguration = null);
+        IFacetOperations Facet(string field, Action<IFacetQueryField>? facetConfiguration = null);
 
         /// <summary>
         /// Add a facet string to the current query, filtered by a single value or multiple values
@@ -23,7 +23,7 @@ public interface IFacetOperations : IQueryExecutor
         /// <param name="facetConfiguration"></param>
         /// <param name="values"></param>
         /// <returns></returns>
-        IFacetOperations Facet(string field, Action<IFacetQueryField> facetConfiguration = null, params string[] values);
+        IFacetOperations Facet(string field, Action<IFacetQueryField>? facetConfiguration = null, params string[] values);
 
         /// <summary>
         /// Add a range facet to the current query

src/Examine.Lucene/Search/FacetFullTextField.cs

@@ -29,13 +29,13 @@ public class FacetFullTextField : IFacetField
         /// <summary>
         /// Path hierachy
         /// </summary>
-        public string[] Path { get; internal set; }
+        public string[]? Path { get; internal set; }
 
         /// <inheritdoc/>
         public bool IsTaxonomyIndexed { get; }
 
         /// <inheritdoc/>
-        public FacetFullTextField(string field, string[] values, string facetField, int maxCount = 10, string[] path = null, bool isTaxonomyIndexed = false)
+        public FacetFullTextField(string field, string[] values, string facetField, int maxCount = 10, string[]? path = null, bool isTaxonomyIndexed = false)
         {
             Field = field;
             Values = values;

src/Examine.Lucene/Search/LuceneFacetExtractionContext.cs

@@ -8,7 +8,7 @@ namespace Examine.Lucene.Search
     public class LuceneFacetExtractionContext : IFacetExtractionContext
     {
 
-        private SortedSetDocValuesReaderState _sortedSetReaderState = null;
+        private SortedSetDocValuesReaderState? _sortedSetReaderState = null;
 
         /// <inheritdoc/>
         public LuceneFacetExtractionContext(FacetsCollector facetsCollector, ISearcherReference searcherReference, FacetsConfig facetConfig)

src/Examine.Lucene/Search/LuceneFacetOperation.cs

@@ -23,13 +23,13 @@ public LuceneFacetOperation(LuceneSearchQuery search)
         }
 
         /// <inheritdoc/>
-        public ISearchResults Execute(QueryOptions options = null) => _search.Execute(options);
+        public ISearchResults Execute(QueryOptions? options = null) => _search.Execute(options);
 
         /// <inheritdoc/>
-        public IFacetOperations Facet(string field, Action<IFacetQueryField> facetConfiguration = null) => _search.FacetInternal(field, facetConfiguration, Array.Empty<string>());
+        public IFacetOperations Facet(string field, Action<IFacetQueryField>? facetConfiguration = null) => _search.FacetInternal(field, facetConfiguration, Array.Empty<string>());
 
         /// <inheritdoc/>
-        public IFacetOperations Facet(string field, Action<IFacetQueryField> facetConfiguration = null, params string[] values) => _search.FacetInternal(field, facetConfiguration, values);
+        public IFacetOperations Facet(string field, Action<IFacetQueryField>? facetConfiguration = null, params string[] values) => _search.FacetInternal(field, facetConfiguration, values);
 
         /// <inheritdoc/>
         public IFacetOperations Facet(string field, params DoubleRange[] doubleRanges) => _search.FacetInternal(field, doubleRanges);

src/Examine.Lucene/Search/LuceneSearchQuery.cs

@@ -338,7 +338,7 @@ public IBooleanOperation SelectAllFieldsInternal()
         /// <returns></returns>
         protected override LuceneBooleanOperationBase CreateOp() => new LuceneBooleanOperation(this);
 
-        internal IFacetOperations FacetInternal(string field, Action<IFacetQueryField> facetConfiguration, params string[] values)
+        internal IFacetOperations FacetInternal(string field, Action<IFacetQueryField>? facetConfiguration, params string[] values)
         {
             if(values == null)
             {

src/Examine.Test/ExamineBaseTest.cs

@@ -21,7 +21,7 @@ public virtual void Setup()
             loggerFactory.CreateLogger(typeof(ExamineBaseTest)).LogDebug("Initializing test");
         }
 
-        public TestIndex GetTestIndex(Directory d, Analyzer analyzer, FieldDefinitionCollection? fieldDefinitions = null, IndexDeletionPolicy? indexDeletionPolicy = null, IReadOnlyDictionary<string, IFieldValueTypeFactory>? indexValueTypesFactory = null, FacetsConfig? facetsConfig = null)
+        public TestIndex GetTestIndex(Directory d, Analyzer analyzer, FieldDefinitionCollection fieldDefinitions = null, IndexDeletionPolicy indexDeletionPolicy = null, IReadOnlyDictionary<string, IFieldValueTypeFactory> indexValueTypesFactory = null, FacetsConfig facetsConfig = null)
         {
             var loggerFactory = LoggerFactory.Create(builder => builder.AddConsole().SetMinimumLevel(LogLevel.Debug));
             return new TestIndex(