QG

Author: kaufco

java-checks-testkit/src/test/java/org/sonar/java/checks/verifier/TestCheckRegistrarContextTest.java

@@ -19,8 +19,11 @@
 import java.util.List;
 import org.junit.jupiter.api.Test;
 import org.sonar.api.rule.RuleKey;
+import org.sonar.api.rule.RuleScope;
 import org.sonar.check.Rule;
 import org.sonar.plugins.java.api.JavaCheck;
+import org.sonar.plugins.java.api.JavaFileScanner;
+import org.sonar.plugins.java.api.JavaFileScannerContext;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -125,4 +128,34 @@ void should_fail_if_not_a_JavaCheck() {
       .hasMessage("Fail to instantiate class java.lang.Object");
   }
 
+  @Test
+  void register_custom_file_scanners_with_no_active_rules() {
+    class DummyScanner implements JavaFileScanner {
+      @Override
+      public void scanFile(JavaFileScannerContext context) {
+        // Dummy implementation. We just need the class instance
+      }
+    }
+
+    class MainScanner extends DummyScanner {
+    }
+
+    class TestScanner extends DummyScanner {
+    }
+
+    class AllScanner extends DummyScanner {
+    }
+
+    var ctx = new TestCheckRegistrarContext();
+    ctx.registerCustomFileScanner(RuleScope.MAIN, new MainScanner());
+    ctx.registerCustomFileScanner(RuleScope.TEST, new TestScanner());
+    ctx.registerCustomFileScanner(RuleScope.ALL, new AllScanner());
+
+    assertThat(ctx.mainCheckInstances)
+      .extracting(c -> c.getClass().getSimpleName())
+      .containsExactly("MainScanner", "AllScanner");
+    assertThat(ctx.testCheckInstances)
+      .extracting(c -> c.getClass().getSimpleName())
+      .containsExactly("TestScanner", "AllScanner");
+  }
 }

java-frontend/src/test/java/org/sonar/java/SonarComponentsTest.java

@@ -416,22 +416,20 @@ void register_custom_file_scanners_with_no_active_rules() {
     CheckFactory specificCheckFactory = new CheckFactory(noActiveRules);
     SensorContextTester specificContext = SensorContextTester.create(new File(".")).setActiveRules(noActiveRules);
 
-    class MainScanner implements JavaFileScanner {
+    class DummyScanner implements JavaFileScanner {
       @Override
       public void scanFile(JavaFileScannerContext context) {
+        // Dummy implementation. We just need the class instance
       }
     }
 
-    class TestScanner implements JavaFileScanner {
-      @Override
-      public void scanFile(JavaFileScannerContext context) {
-      }
+    class MainScanner extends DummyScanner {
     }
 
-    class AllScanner implements JavaFileScanner {
-      @Override
-      public void scanFile(JavaFileScannerContext context) {
-      }
+    class TestScanner extends DummyScanner {
+    }
+
+    class AllScanner extends DummyScanner {
     }
 
     SonarComponents sonarComponents = new SonarComponents(fileLinesContextFactory, null, null,

java-frontend/src/test/java/org/sonar/plugins/java/api/CheckRegistrarTest.java

@@ -27,6 +27,7 @@
 import static java.util.Collections.emptyList;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -96,6 +97,12 @@ class Scanner implements JavaCheck {
       "register 3 instantiated test checks.");
   }
 
+  @Test
+  void empty_default_method_coverage() {
+    var context = new CheckRegistrar.RegistrarContext();
+    assertDoesNotThrow(() -> context.registerCustomFileScanner(null, null));
+  }
+
   private static class TestInternalRegistration extends CheckRegistrar.RegistrarContext {
 
     public final List<String> events = new ArrayList<>();