Skip to content

Table theming issues #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skwerlman opened this issue Sep 26, 2017 · 5 comments
Closed

Table theming issues #28

skwerlman opened this issue Sep 26, 2017 · 5 comments

Comments

@skwerlman
Copy link

Bright greys:
image
A weird grey bar:
image

https://en.wikipedia.org/wiki/Myst_(series)

@Mottie
Copy link
Member

Mottie commented Sep 26, 2017

Hi @skwerlman!

If you look at the limitations section of the readme, you'll see a note about how Wikipedia uses inline styles to add background colors to table cells. There are only two solutions that I can think of:

  1. Ignore all custom table cell colors and override them all.
  2. Add every single color combination, full and shorthand hex colors, with and without spaces, and include th and td cells.

The first would be easy, but not pretty. The second... well, I don't have the time to do something like that. My OCD would be relieved, but my wife would hate me.

The "weird grey bar" is because that's how the creator of the page added padding:

<div style="font-size:90%;float:right;border-left:1em solid white;">...</div>

This style is targeting the "white" border... I guess I could force the width to be 1px, but then I would have to add some padding. And I don't even want to think about how that would effect other pages. There are no classes or easy methods to target and fix this problem. Maybe someone needs to edit the wiki page and fix it?

TLDR; There's not much I can do with this userstyle.

@Mottie
Copy link
Member

Mottie commented Sep 26, 2017

Hmm, ok maybe I can fix this one... it's the tr with the style, not the td... I guess I should have looked at the source before replying.

And I edited the wiki page... YAY for padding.

@Mottie Mottie closed this as completed in 81d34c9 Sep 26, 2017
@hartman
Copy link

hartman commented Sep 26, 2017

I've made some further changes to update the table to be better inline with our current standards. That thing was old....

P.S. that technique was originally used by thumbnails, long long ago, to create spacing between the text and the floating frames. But we have long since moved away from that methodology.

@skwerlman
Copy link
Author

Thanks for getting this figured out and fixed ❤️

@Mottie
Copy link
Member

Mottie commented Sep 26, 2017

I just fixed the diff page styling as well 😸.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants