Skip to content

Fix colour menu #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alzter opened this issue Jul 4, 2020 · 4 comments · Fixed by #1456
Closed

Fix colour menu #1451

Alzter opened this issue Jul 4, 2020 · 4 comments · Fixed by #1456

Comments

@Alzter
Copy link
Member

Alzter commented Jul 4, 2020

SuperTux version: 0.6.2
System information: Windows 10

Currently, the colour menu displays its values as percentages when it's opened.
image

This is problematic as when you try to edit these values the slider breaks, and the only way you can input colours is through a decimal input.
image

I think it'd be good to revert the colour menu to display the values in decimals when it's opened.

@HybridDog
Copy link
Contributor

HybridDog commented Jul 4, 2020

This is problematic as when you try to edit these values the slider breaks

How can you edit the values?
When I changed the colour menu, I didn't know that editing them without the sliders in the editor is possible. Is there a key combination for this?

I think it'd be good to revert the colour menu to display the values in decimals when it's opened.

I have changed the the displayed string so that it shows the colour number in linear RGB colourspace in percent. SuperTux uses sRGB values, so if someone wants to make something half as bright in a real (non-perceived) way, linear number values should be shown.
I'm fine with a change where both are shown, e.g. 0.5 (19 %).

Here's the related commit: 27ae58c

@Rusty-Box
Copy link
Member

How can you edit the values?
When I changed the colour menu, I didn't know that editing them without the sliders in the editor is possible. Is there a key combination for this?

@HybridDog You can by simply pressing backspace to remove the value and typing a new value between 0 and 1. I didn't even know you could use a the sliders. I only new the typing option. :D

@HybridDog
Copy link
Contributor

I have tried to fix the problem in #1456. I hope it works correctly and does not break other things.

@Alasdairbugs
Copy link
Contributor

i just used the arrow keys and it never broke for me.

however i prefer the old method as you can have a larger variety of colours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants